-
Couldn't load subscription status.
- Fork 1.3k
board: add board waveshare_esp32_s3_touch_lcd_1_47 #10689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definition looks fine to me. Please request a new PID from Espressif for the touch variant instead of using the UF2 PID. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the UF2 bootloader PID. Please request a new set for this board.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tannewt for the pointer! https://github.com/espressif/usb-pids/blob/main/allocated-pids.txt#L813C3-L813C7, got a new set of PIDs and updated the PR here with the assigned value.
Thanks!
42e2cdb to
b076e08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Adds a new board for Waveshare ESP32 S3 Touch LCD 1.47. The implementation is based on the official Waveshare documentation on the board ESP32-S3-Touch-LCD-1.47.
The display driver is a new model JD9853, and the init sequence is ported from Waveshare's Arduino example.
The pin assignment follows the pin definition from Waveshare Wiki.
image