Skip to content

Fix ada.o object build #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

bbayles merged 1 commit into ada-url:main from jameshilliard:fix-setuptools-build

Sep 5, 2024

Merged

Fix ada.o object build #92

bbayles merged 1 commit into ada-url:main from jameshilliard:fix-setuptools-build

Sep 5, 2024

Conversation

Copy link

Contributor

@jameshilliard jameshilliard commented Aug 29, 2024

Should fix #49.

@jameshilliard jameshilliard force-pushed the fix-setuptools-build branch 14 times, most recently from 1130d3d to 5cdee76 Compare

August 29, 2024 17:43

Copy link

Contributor Author

jameshilliard commented Aug 29, 2024

I think tests should now all be passing.

anonrig approved these changes

View reviewed changes

@anonrig anonrig requested a review from bbayles

August 29, 2024 21:47

Copy link

Collaborator

bbayles commented Aug 30, 2024

Hmm, this breaks on my machine:

ada_url/ada.cpp:11791:31: error: 'value' is unavailable: introduced in macOS 10.13
 helpers::encode_json(hash.value(), back);
 ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/optional:1057:33: note: 'value' has been explicitly marked unavailable here
 constexpr value_type const& value() const&
 ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.

Any ideas?

@jameshilliard jameshilliard force-pushed the fix-setuptools-build branch 4 times, most recently from 389f67e to 0e45549 Compare

September 5, 2024 16:23

Copy link

Contributor Author

jameshilliard commented Sep 5, 2024 •

edited

Loading

introduced in macOS 10.13

Looks like you need to set the MACOSX_DEPLOYMENT_TARGET.

I'm assuming you are running an outdated OSX or xcode version since the latest version doesn't seem to need to have this set from what I can tell.

bbayles reviewed

View reviewed changes

pyproject.toml Show resolved Hide resolved


 Fix ada.o object build

50c9663

@jameshilliard jameshilliard force-pushed the fix-setuptools-build branch from 0e45549 to 50c9663 Compare

September 5, 2024 17:18

Copy link

Collaborator

bbayles commented Sep 5, 2024

Thanks for this - great work!

@bbayles bbayles merged commit 4c0ed2e into ada-url:main

@jameshilliard jameshilliard mentioned this pull request

Set minimum cffi version instead of maximum setuptools version #95

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jameshilliard @bbayles @anonrig