-
-
Notifications
You must be signed in to change notification settings - Fork 26
Fix retry on upcoming assertions #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abhinaba-ghosh
merged 2 commits into
abhinaba-ghosh:master
from
daniele-pini:fix_retry_upcoming_assertions
Jun 17, 2022
Merged
Fix retry on upcoming assertions #340
abhinaba-ghosh
merged 2 commits into
abhinaba-ghosh:master
from
daniele-pini:fix_retry_upcoming_assertions
Jun 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
daniele-pini
commented
Jun 17, 2022
@abhinaba-ghosh, was there a specific reason to add the then() at the end? I'm wondering because it doesn't seem to have a purpose, but maybe I'm wrong?
Owner
abhinaba-ghosh
commented
Jun 17, 2022
Hi @daniele-pini thanks for raising this PR. This makes sense.
abhinaba-ghosh
abhinaba-ghosh
approved these changes
Jun 17, 2022
Owner
abhinaba-ghosh
commented
Jun 17, 2022
This should be available in version 2.3.19
Contributor
Author
daniele-pini
commented
Jun 17, 2022
👍 Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes retries for upcoming assertions on commands
reactandgetReact. Closes #339.