Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Major Bug Fixes and Improvements (Fixes #61) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhiTronix merged 11 commits into master from patch@buildscript
Feb 5, 2021
Merged

Conversation

@abhiTronix
Copy link
Owner

@abhiTronix abhiTronix commented Jan 23, 2021

Fixes #61

- Extended build-script sysroot patch to `RTBuilder_32b`.
- Replaced incorrect `RPI_TYPE` with `FOLDER_VERSION`.
- Replaced `OS_TYPE` with `RPIOS_TYPE` in `RTBuilder_64b.
- Added Buster and Stretch native support for `RTBuilder_64b` build script.
- Updated CI Bash scripts with new `-o` flag to support OS selection.
- Updated YAMLs to include buster & stretch Pi OS support.
- Updated and added new docs.
@abhiTronix abhiTronix added Bug 🐛 Error, flaw or fault Enhancement 😃 New Feature/Addition/Improvement Docs 📚 Wiki Documentaion related WIP 🏗️ Work in Progress labels Jan 23, 2021
@abhiTronix abhiTronix added this to the v3.0.5 milestone Jan 23, 2021
@abhiTronix abhiTronix self-assigned this Jan 23, 2021
VERBOSE=1
echo "Info: Activated verbose output!"
echo ""
set -eov pipefail # Set verbose mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. The script will fail on error only if someone chooses the verbose option. Errors would still be silently ignored otherwise.

Wouldn't it make sense to put set -eo pipefail at the top of every script and call set -v during cmdline parsing in scripts which support the verbose option?

abhiTronix reacted with thumbs up emoji
* Strip on compiler install (#39)
 * This drastically reduces extracted size from 1.7GB to 477MB
* Followup to pull request #62
 * Set "set -eo pipefail" at top of script. Set "set -v" only for verbose
 mode
 * Fix wget download of linux kernel
 * The out wget was failing because of multiple lines. Only consider
 topmost line with most recent file)
visglz and others added 4 commits February 4, 2021 08:35
"set -eo pipefail" is already set at top of script.
Strip compiler executables and minor fixes
- Updated strip patch for all bash-scripts for smaller binary size.
- Updated assets.
- Updated docs.
@abhiTronix abhiTronix merged commit 7ead221 into master Feb 5, 2021
@abhiTronix abhiTronix deleted the patch@buildscript branch February 5, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@visglz visglz visglz left review comments

Reviewers whose approvals may not affect merge requirements

Labels

Bug 🐛 Error, flaw or fault Docs 📚 Wiki Documentaion related Enhancement 😃 New Feature/Addition/Improvement WIP 🏗️ Work in Progress

Projects

None yet

Milestone

v3.0.5

Development

Successfully merging this pull request may close these issues.

Crosscompile for 64 Bit Debian 10

AltStyle によって変換されたページ (->オリジナル) /