-
Notifications
You must be signed in to change notification settings - Fork 129
Ensuring logical correctness via modulo operations #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
liujinhui-job
wants to merge
1
commit into
Xilinx-CNS:master
from
liujinhui-job:avoid_dmaq_insert_seq_wraparound
Closed
Ensuring logical correctness via modulo operations #296
liujinhui-job
wants to merge
1
commit into
Xilinx-CNS:master
from
liujinhui-job:avoid_dmaq_insert_seq_wraparound
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensuring logical correctness via modulo operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tx_dmaq_insert_seq variable continuously performs increment (++) operations.
When it reaches the maximum value of 0xFFFFFFFF and continues incrementing, it wraps around to 0.
At this point, the value of tx_dmaq_insert_seq_last_poll remains very large, causing the ci_netif_poll function to be unable to be called for an extended period.
Modify it to use a modulo operation to ensure logical correctness.