-
Notifications
You must be signed in to change notification settings - Fork 354
[ php-wasm ] Refactor php-wasm-cli to maintain consistency across CLIs #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mho22, these changes look good to me.
Add index.ts file with exportable functions ?
Do we have any need of this today? If not, maybe we can wait until there is a need.
Sort directories in playground-cli [ /src > /src/lib & /src/tests ] ?
If this is generally our pattern in many other Playground and php-wasm packages, this seems like a good idea.
Do we have any need of this today? If not, maybe we can wait until there is a need.
I agree, we'll build this if we need it one day.
If this is generally our pattern in many other Playground and php-wasm packages, this seems like a good idea.
Ok. On it.
I asked for a review but I should create tests for the PHP.wasm CLI first.
83ca72b to
0c3ca9c
Compare
Uh oh!
There was an error while loading. Please reload this page.
Motivation for the change
π§ This is experimental π§
Based on a suggestion made in a comment from this pull request.
This pull request aims to maintain consistency across the different CLI structures.
Implementation details
php-wasm-cli
yargsto parse options inmain.tsasrun-cli.tsand rename referencesrun-cli.tsfile insrc/libdirectorycli.tsfile insrcdirectoryindex.tsfile insrcdirectoryrunCLIfunctions intoparseOptionsAndRunCLIyargsusage display between CLIsxdebug-bridge
runCLIfunctions intoparseOptionsAndRunCLIplayground-cli
yargsusage display between CLIsplayground-cli[ /src > /src/lib & /src/tests ] ?