-
Notifications
You must be signed in to change notification settings - Fork 60
Refactor Theme_Readme (readme.txt) PHP class #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
admin/create-theme/theme-readme.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also builds one for BLANK themes, so probably drop the "for CHILD/GRANDCHILD themes" part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed here: 3e1bd60
...ed it out to get all sections.
I found that the "Recommend Plugins" wasn't being sent back to the client (though it was being persisted if edited from the client).
I did a lil' refactoring, pulling the logic to get that and send it to the client from the "utils" class to the "readme" class and had it pull all the sections, not just look exclusively for the "recommended plugins" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is working great! Code looks great, huge improvement.
If you're OK with my additions then I think this is ready to come in!
I found that the "Recommend Plugins" wasn't being sent back to the client (though it was being persisted if edited from the client).
Haha yep, I created an issue about the same #631
I did a lil' refactoring, pulling the logic to get that and send it to the client from the "utils" class to the "readme" class and had it pull all the sections, not just look exclusively for the "recommended plugins" section.
Cool, good addition.
Uh oh!
There was an error while loading. Please reload this page.
What?
Why?