-
Notifications
You must be signed in to change notification settings - Fork 319
Fix Build on UE 5.0.3 #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Phyronnaz
commented
Oct 27, 2022
Thanks for the PR! We're indeed working on a big update internally so this won't apply to that, but I'll merge it into this repo so people can use it on 5 :)
Phyronnaz
added a commit
that referenced
this pull request
Jun 13, 2024
Fix Build on UE 5.0.3 Former-commit-id: c14b8c6cf4a314ae92618f34af3e1ec9c1b2c945 [formerly a1c5910] Former-commit-id: 90c7e58d3efd60b3db2b33983e219a10605d3cc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have heard that an update is coming, yet it was a fun exercise to do. I hope it will help some people who want to get started with the pluggin on UE5 in the meantime 😁
What does this PR do?
fix #441, fix #440, and maybe #439
Added the macro
UE_5_CONVERTinVoxelEngineVersionHelpers.hto convert some data types to the API changes (it has a cost because we are making a new object on the stack, not casting).Used the macro
UE_5_SWITCHon several places to adapt to the API changes (when needed, used a check againstVOXEL_ENGINE_VERSION). As some variables are now postfixed as DEPRECATED some places will need bigger revamps in the near future.Hide minor textures in UE5 from the Voxel details panel as they are now missing.
sample
How was this PR tested?
Tested on UE 5.0.3 as well as UE 4.27.2 that build works. Looked for regression by using side-to-side engines (might have missed some bits as I'm a newbie user)