-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix/heap corruption #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/heap corruption #913
Conversation
- Change HuffmanDictionary::new() to return Option<Self> for safer API - Add proper handling for empty alphabet (returns None) - Add special case handling for single-symbol alphabets - Replace unwrap() calls with ? operator in decode() for better error handling - Add #[inline(always)] optimization for frequently called get_bit() - Add comprehensive tests for edge cases - Improve documentation with usage examples BREAKING CHANGE: HuffmanDictionary::new() now returns Option<Self>
codecov-commenter
commented
Sep 25, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #913 +/- ## ======================================= Coverage 95.32% 95.32% ======================================= Files 319 319 Lines 20807 20858 +51 ======================================= + Hits 19834 19883 +49 - Misses 973 975 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Pull Request Template
Description
Fix heap corruption in Floyd's algorithm tests
Problem
The test
test_detect_cycle_with_cyclecreates a cycle in a LinkedList but doesn't break it before the list is dropped. This causes heap corruption because the Drop implementation tries to free nodes in an infinite loop, potentially causing double-frees.Solution
Break the cycle at the end of the test by setting the tail's next pointer to None.
Testing
cargo test data_structuresmultiple times without heap corruption errors--test-threads=1for consistencyFixes intermittent test failures with "Heap corruption detected" errors.
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.Note I ran cargo clippy --all -- -D warnings locally, and the build fails due to 24 existing warnings/errors (e.g., clippy::manual-is-multiple-of, clippy::needless-range-loop) in unrelated files (ciphers, math, sorting).
cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.COUNTRIBUTING.mdand my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.