Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cycle sort tests #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 13 commits into TheAlgorithms:master from charliejmoore:cycle-sort-tests
Oct 6, 2021
Merged

Conversation

@charliejmoore
Copy link
Contributor

@charliejmoore charliejmoore commented Oct 4, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Adds tests

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

Please resolve the conflicts.

charliejmoore reacted with thumbs up emoji

@raklaptudirm raklaptudirm added changes required This pull request needs changes feature Adds a new feature labels Oct 6, 2021
Copy link
Contributor Author

Please resolve the conflicts.

Ok @raklaptudirm conflicts resolved! :)

@raklaptudirm raklaptudirm merged commit 7c9219d into TheAlgorithms:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

changes required This pull request needs changes feature Adds a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /