Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Sliding Window Algorithem #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
morMBen wants to merge 6 commits into TheAlgorithms:master from morMBen:patch-1
Closed

Conversation

@morMBen
Copy link
Contributor

@morMBen morMBen commented Sep 4, 2021

I have now used Standard.js
Hope everything is to your satisfaction.

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • [ V] Add an algorithm?

Checklist:

  • [V] I have read CONTRIBUTING.md.
  • [V] This pull request is all my own work -- I have not plagiarized.
  • [V] I know that pull requests will not be merged if they fail the automated tests.
  • [V] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [V] All new JavaScript files are placed inside an existing directory.
  • [ V All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
 

I have now used Standard.js
Hope everything is to your satisfaction.
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving the tests into a separate jest file. See the test subdirectory for more details.

Copy link
Member

Sorry, I mistakenly closed it.

@raklaptudirm raklaptudirm added changes required This pull request needs changes Reviewed labels Sep 12, 2021 
hope now everything is fine.
Copy link
Member

@morMBen Please move the tests as i mentioned.

 

I did remove the test functions and put them in the subdirectory test in a file called SlidingWindow.test.js.
As you requested I moved the tests here
Copy link
Contributor Author

morMBen commented Sep 22, 2021

As you requested I moved the tests.
raklaptudirm reacted with thumbs up emoji

Copy link
Member

You forgot to use standard.js.

Copy link
Contributor Author

morMBen commented Sep 22, 2021

You're right, I'm just getting used to using it right now.
Done :)
raklaptudirm reacted with thumbs up emoji

Copy link
Member

Seems like you still have some problems.

Copy link
Contributor Author

morMBen commented Sep 22, 2021

I did a new pull request that should work, hopefully, it'll work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm requested changes

+1 more reviewer

@Maker-Mark Maker-Mark Maker-Mark left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changes required This pull request needs changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /