-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Added implementations of Runga kutta method along with test cases for Hacktoberfest contribution #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added implementations of Runga kutta method along with test cases for Hacktoberfest contribution #1710
Conversation
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.72%. Comparing base (
9010481) to head (7214c0a).
Additional details and impacted files
@@ Coverage Diff @@ ## master #1710 +/- ## ========================================== + Coverage 84.65% 84.72% +0.06% ========================================== Files 378 379 +1 Lines 19744 19824 +80 Branches 2951 2955 +4 ========================================== + Hits 16715 16795 +80 Misses 3029 3029
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating new variables here is unnecessary as xStart and yStart are never used later. Renaming the variables to x and y and just using them would be better. This would also allow you to use the object shorthand syntax:
const points = [{ x, y }] // Line 55 points.push({ x, y }) // Line 76
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.