algorithm: quadratic formula #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

YorLecaros wants to merge 3 commits into TheAlgorithms:master

from YorLecaros:feature/QuadraticFormula

Open

algorithm: quadratic formula #1151

YorLecaros wants to merge 3 commits into TheAlgorithms:master from YorLecaros:feature/QuadraticFormula

Conversation

@YorLecaros


 [FEATURE] Added Quadratic Formula to Maths Folder

047351b

@YorLecaros YorLecaros requested review from appgurueu and raklaptudirm as code owners

October 9, 2022 01:36

appgurueu

appgurueu reviewed

Oct 9, 2022

View reviewed changes

Maths/test/QuadraticFormula.test.js Outdated

@@ -0,0 +1,21 @@

import { quadraticFormula } from '../QuadraticFormula'

test('Testing on quadraticFormula', () => {

Copy link

Collaborator

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/TheAlgorithms/TypeScript/blob/master/CONTRIBUTING.md#writing-good-tests

appgurueu

appgurueu reviewed

Oct 9, 2022

View reviewed changes

Maths/QuadraticFormula.js Outdated

* @example quadraticFormula(1, -3, 8) = 'the roots do not exist or the roots are imaginary'

const quadraticFormula = (a, b, c) => {

Copy link

Collaborator

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to solveQuadraticEquation

Copy link

Author

@YorLecaros YorLecaros Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, no problem 👍

appgurueu

appgurueu reviewed

Oct 9, 2022

View reviewed changes

Maths/QuadraticFormula.js Outdated

}

const discriminant = (b ** 2) - (4 * a * c)

const denominator = 2 * a

let answer = ''

Copy link

Collaborator

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use strings; instead, return an array of solutions (empty array for no solutions, array with single item for one solution, two items for two solutions).

Copy link

Author

@YorLecaros YorLecaros Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll do that...thanks!

@YorLecaros


 [UPDATE] Return type and function name changed, improved test file

19691c6

appgurueu

appgurueu reviewed

Oct 9, 2022

View reviewed changes

Maths/QuadraticFormula.js Outdated

const denominator = 2 * a

let answer = ''

let answer = []

if (discriminant >= 0) {

Copy link

Collaborator

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please distinguish discriminant == 0 here to only add a single item to answer in that case.

appgurueu

appgurueu reviewed

Oct 9, 2022

View reviewed changes

Maths/test/QuadraticFormula.test.js Show resolved Hide resolved

@YorLecaros


 [UPDATE] added new validation

a74ba8e

appgurueu

appgurueu approved these changes

Oct 9, 2022

View reviewed changes

@appgurueu

Copy link

Collaborator

appgurueu commented Oct 9, 2022

Please don't forget to rename the file.

raklaptudirm

raklaptudirm approved these changes

Oct 10, 2022

View reviewed changes

@raklaptudirm raklaptudirm changed the title ~~(削除) [FEATURE] Added Quadratic Formula to Maths Folder (削除ここまで)~~ (追記) algorithm: quadratic formula (追記ここまで)

Oct 10, 2022

@stale

Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label

Nov 2, 2022

Labels

stale

3 participants

@YorLecaros @appgurueu @raklaptudirm

Uh oh!

algorithm: quadratic formula #1151

Are you sure you want to change the base?

algorithm: quadratic formula #1151

Uh oh!

Conversation

@YorLecaros YorLecaros commented Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

@YorLecaros YorLecaros Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

@YorLecaros YorLecaros Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

@appgurueu appgurueu Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

appgurueu commented Oct 9, 2022

Uh oh!

stale bot commented Nov 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@YorLecaros YorLecaros commented Oct 9, 2022 •

edited

Loading