-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix Affine-Cipher encrypt and drypt func #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raklaptudirm
merged 3 commits into
TheAlgorithms:master
from
shidian00:fix-encrypt-and-decrypt-func
Aug 3, 2022
Merged
Fix Affine-Cipher encrypt and drypt func #1077
raklaptudirm
merged 3 commits into
TheAlgorithms:master
from
shidian00:fix-encrypt-and-decrypt-func
Aug 3, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shidian00
shidian00
requested review from
appgurueu and
raklaptudirm
as code owners
August 2, 2022 19:06
appgurueu
appgurueu
approved these changes
Aug 3, 2022
raklaptudirm
raklaptudirm
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open in Gitpod know more
Describe your change:
encrypt func should return alphabet instead of numbers string
add checking for coprime as if coefficient 'a' is not coprime to 26 will reusultant in invalid result in inverse mod
modify some test case
Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.