-
Notifications
You must be signed in to change notification settings - Fork 17
Make table diff ignore newlines #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gkubisa
merged 1 commit into
Teamwork:master
from
zanderle:table-diffs-should-ignore-newlines
Feb 25, 2025
Merged
Make table diff ignore newlines #46
gkubisa
merged 1 commit into
Teamwork:master
from
zanderle:table-diffs-should-ignore-newlines
Feb 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a table is provided in multiple lines in the HTML, that shouldn't mark the whole table as invalid. So before we compare the elements of a table we should first trim any #text nodes, and ignore them if they're empty
@zanderle
zanderle
force-pushed
the
table-diffs-should-ignore-newlines
branch
from
February 20, 2025 12:39
e6ac6f5 to
6e3e97e
Compare
@zanderle
zanderle
changed the title
(削除) WIP Make table diff ignore newlines (削除ここまで)
(追記) Make table diff ignore newlines (追記ここまで)
Feb 20, 2025
Thank you for the contribution @zanderle ! 👍
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table is provided in multiple lines in the HTML, that shouldn't mark the whole table as invalid. So before we compare the elements of a table we should first trim any #text nodes, and ignore them if they're empty