Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

manifestFiles could exist for direct but be none. fixed the check #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dacoburn merged 1 commit into main from doug/another-fix-for-none-manifest
Jun 30, 2025

Conversation

@dacoburn
Copy link
Collaborator

@dacoburn dacoburn commented Jun 30, 2025

Root Cause

Direct dependency manifestFiles could still be None breaking iteration

Fix

Correctly returned if attribute didn't exist OR was None

Public Changelog

N/A

@dacoburn dacoburn requested a review from a team as a code owner June 30, 2025 16:28
@dacoburn dacoburn requested review from Planeshifter and ammkrn and removed request for a team June 30, 2025 16:28
Copy link

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.17.dev1

Docker image: socketdev/cli:pr-96

@dacoburn dacoburn merged commit 04b4420 into main Jun 30, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/another-fix-for-none-manifest branch June 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmeck bmeck bmeck approved these changes

@Planeshifter Planeshifter Awaiting requested review from Planeshifter Planeshifter is a code owner automatically assigned from SocketDev/eng

@ammkrn ammkrn Awaiting requested review from ammkrn ammkrn is a code owner automatically assigned from SocketDev/eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /