Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated version for build #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dacoburn merged 1 commit into main from doug/fix-empty-report-error
Apr 3, 2025
Merged

Updated version for build #67

dacoburn merged 1 commit into main from doug/fix-empty-report-error
Apr 3, 2025

Conversation

@dacoburn
Copy link
Collaborator

@dacoburn dacoburn commented Apr 3, 2025

CLI could have a failure if the Full Scan was empty

Root Cause

get_sbom_data would try to reference response.artifacts which didn't exist if the full scan was empty

Fix

Added a check for the class attribute and if not present just return the empty result

Public Changelog

  • Fixed an issue that could lead to the Python CLI failing if the full scan had no results

@dacoburn dacoburn added the Product Changelog New features for the public changelog label Apr 3, 2025
@dacoburn dacoburn requested a review from a team as a code owner April 3, 2025 01:03
@dacoburn dacoburn requested review from philidem and tmpvar and removed request for a team April 3, 2025 01:03
Copy link

github-actions bot commented Apr 3, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.35.dev1

Docker image: socketdev/cli:pr-67

@dacoburn dacoburn merged commit 17db071 into main Apr 3, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-empty-report-error branch April 3, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philidem philidem philidem approved these changes

@tmpvar tmpvar Awaiting requested review from tmpvar tmpvar is a code owner automatically assigned from SocketDev/eng

Assignees

No one assigned

Labels

Product Changelog New features for the public changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /