-
Notifications
You must be signed in to change notification settings - Fork 8
Doug/fix supported files #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dacoburn
dacoburn
added
the
Product Changelog
New features for the public changelog
label
Mar 18, 2025
@dacoburn
dacoburn
requested review from
bmeck and
rchatrath7
and removed request for
a team
March 18, 2025 23:46
🚀 Preview package published!
Install with:
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.14.dev633
Docker image: socketdev/cli:pr-63
reberhardt7
reberhardt7
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In moving to using the supported files endpoint to get the patterns for manifest files it broke the detection for some of the Manifest types due to being regex patterns and not glob patterns.
Root Cause
Moving to Supported API and not accounting for patterns being regex and not glob
Fix
Added functions to convert the regex patterns to globs.
Public Changelog