-
Notifications
You must be signed in to change notification settings - Fork 8
Eric/use types and logging #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@flowstate
flowstate
requested review from
alxhotel and
rchatrath7
and removed request for
a team
March 10, 2025 23:00
🚀 Preview package published!
Install with:
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.12.dev615
Docker image: socketdev/cli:pr-61
@flowstate
flowstate
requested review from
dacoburn
and removed request for
alxhotel and
rchatrath7
March 10, 2025 23:06
dacoburn
dacoburn
requested changes
Mar 10, 2025
dacoburn
dacoburn
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
We thought we need to add
use_types=True, but there are no types for the post method in the SDK.The actual problem was that the SDK's repos.post method has the following code:
So the fix was to check for success by checking if the response had content or not.
I've also wrapped this create call in its own try/except, and if it fails we log it and exit with code 2.
So now if both calls fail there won't be an "unexpected error while running the CLI"
======
Proof that the logging issue is gone:
with debug enabled:
without debug: