-
Notifications
You must be signed in to change notification settings - Fork 8
Doug/fix manifest issue #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dacoburn
dacoburn
added
the
Product Changelog
New features for the public changelog
label
Feb 19, 2025
@dacoburn
dacoburn
requested review from
mikolalysenko and
tmpvar
and removed request for
a team
February 19, 2025 19:56
🚀 Preview package published!
Install with:
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.6.dev564
Docker image: socketdev/cli:pr-56
reberhardt7
reberhardt7
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue where
manifestFilescan be non-existent withtop_levelpackages. This can cause the CLI to error out incorrectly.Root Cause
Some results from the
diffendpoint can have package entries where the top level package does not have themanifestFilesattribute. The code was not accounting for this correctly.Fix
Added an explicit check to account for this:
Public Changelog
manifestFilesattribute is not present on a top level package