-
Notifications
You must be signed in to change notification settings - Fork 8
Doug/fix windows support #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add USER_AGENT constant to socketsecurity/__init__.py - Replace hardcoded 'SocketPythonScript/0.0.1' and 'SocketPythonCLI/0.0.1' with centralized USER_AGENT - Update all SCM clients (GitHub, GitLab) and CLI client to use USER_AGENT - Update unit tests to reference centralized constant - Pin GitHub Actions to commit SHAs for improved security and reproducibility - Fix minor GitLab client bugs (return type, pipeline source support)
@dacoburn
dacoburn
requested review from
kapravel and
reberhardt7
and removed request for
a team
October 24, 2025 01:22
🚀 Preview package published!
Install with:
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.15.dev1
Docker image: socketdev/cli:pr-123
@dacoburn
dacoburn
added
the
Product Changelog
New features for the public changelog
label
Oct 24, 2025
tmpvar
tmpvar
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI was broken on Windows due to usage of the Unix-only
resourcemodule, and multiple API clients were using hardcoded, inconsistent User-Agent strings. This caused:Root Cause
Windows Compatibility: The
resource_utils.pymodule unconditionally imported theresourcemodule, which is only available on Unix-like systems (Linux, macOS). This caused an ImportError on Windows, preventing the CLI from running.User-Agent Inconsistency: User-Agent strings were hardcoded in multiple locations (GitLab, GitHub, and CLI clients) rather than being derived from the package version defined in
socketsecurity/__init__.py. Each client independently defined its User-Agent, leading to version drift and inconsistency.Fix
Windows Compatibility Fix:
resourcemodule only on Unix systemsresourcemodule usage in availability checksget_file_descriptor_limit()to return(None, None)on Windowscheck_file_count_against_ulimit()to gracefully handle Windows by returningcan_check: Falseandsafe_to_process: TrueUser-Agent Centralization:
USER_AGENTconstant tosocketsecurity/__init__.pythat uses the actual package version:f'SocketPythonCLI/{__version__}'USER_AGENT:socketsecurity/core/cli_client.pysocketsecurity/core/scm/client.py(GitHub and GitLab clients)socketsecurity/core/scm/github.pysocketsecurity/core/scm/gitlab.pyAdditional Improvements:
Public Changelog