-
Couldn't load subscription status.
- Fork 8
fix: resolve merge commit detection and add production safety features #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dachi-dev
dachi-dev
requested review from
BarrensZeppelin and
hemanthkini
and removed request for
a team
August 25, 2025 22:23
🚀 Preview package published!
Install with:
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.3.0.dev6
Docker image: socketdev/cli:pr-115
@dachi-dev
dachi-dev
requested review from
dacoburn,
dktran65g and
jonathanStrange0
August 25, 2025 22:47
dacoburn
dacoburn
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but lets test with Github Actions and Gitlab Pipelines before merging.
@dachi-dev
dachi-dev
force-pushed
the
fix/merge-commit-detection-and-safety
branch
from
August 30, 2025 20:03
f251f1b to
cb71bd2
Compare
- Add 'reopened' to supported PR actions alongside 'opened' and 'synchronize' - Resolves 'Pull Request Action reopened is not a supported type' error - GitHub Actions workflow already includes reopened trigger, now CLI supports it - Enables diff mode for reopened PRs instead of exiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes critical issues with merge commit file detection that was causing incorrect fallbacks to API mode and adds comprehensive production safety features.
Key Issues Resolved
Git Show Bug Fixed
Customer Guidance:
Enhanced Warnings:
Detection Transparency:
Production Safety:
What This Fixes
Real Detection Examples
Single Commit:
DETECTION SUMMARY: method=single-commit-show files=11 sha=095b0ccc cmd="git show --name-only 095b0ccc..."Merge Commit:
DETECTION SUMMARY: method=merge-diff files=1 sha=b459b2e3 cmd="git diff --name-only 89ca8e3a..b459b2e3"Testing
Public Changelog
N/A