Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed an issue where when there were new alerts the CLI wasn't correc... #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dacoburn merged 1 commit into main from doug/fix-cli-not-failing-on-alerts
Aug 25, 2025

Conversation

@dacoburn
Copy link
Collaborator

@dacoburn dacoburn commented Aug 24, 2025

CLI Is not failing scans when it should be. This means that integrations wouldn't be failed when they should be.

Root Cause

Incorrect alert logic

Fix

Public Changelog

  • Fixed the logic for failing in API Mode

@dacoburn dacoburn requested a review from a team as a code owner August 24, 2025 23:55
@dacoburn dacoburn requested review from jfblaa and trevnorris and removed request for a team August 24, 2025 23:55
Copy link

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.5.dev1

Docker image: socketdev/cli:pr-114

@dacoburn dacoburn merged commit 7af45bc into main Aug 25, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-cli-not-failing-on-alerts branch August 25, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@trevnorris trevnorris Awaiting requested review from trevnorris trevnorris is a code owner automatically assigned from SocketDev/eng

@jfblaa jfblaa Awaiting requested review from jfblaa jfblaa is a code owner automatically assigned from SocketDev/eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /