Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Automatically detect GitHub event action from event payload if not set in workflow #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dacoburn merged 1 commit into main from doug/fix-event-action-being-none
Jul 28, 2025

Conversation

@dacoburn
Copy link
Collaborator

@dacoburn dacoburn commented Jul 28, 2025

Right now the EVENT_ACTION has to be set in the Github Workflow. Trying to simplify things and require less hard coding of variables for the end user.

Root Cause

If the custom variable wasn't set then the EVENT_ACTION was None

Fix

  • Update the Github logic to read the event action from the GITHUB_EVENT_PATH payload file if EVENT_ACTION is not set.

Public Changelog

N/A

...t in environment
- Update the Github logic to read the event action from the GITHUB_EVENT_PATH payload file if EVENT_ACTION is not set.
@dacoburn dacoburn requested a review from a team as a code owner July 28, 2025 23:18
@dacoburn dacoburn requested review from bcomnes and trevnorris and removed request for a team July 28, 2025 23:18
Copy link

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.28.dev1

Docker image: socketdev/cli:pr-105

@dacoburn dacoburn merged commit 20110b3 into main Jul 28, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-event-action-being-none branch July 28, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchatrath7 rchatrath7 rchatrath7 approved these changes

@bcomnes bcomnes Awaiting requested review from bcomnes bcomnes is a code owner automatically assigned from SocketDev/eng

@trevnorris trevnorris Awaiting requested review from trevnorris trevnorris is a code owner automatically assigned from SocketDev/eng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /