-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(Popup): apply Popper attributes to wrapper div #4525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Popup): apply Popper attributes to wrapper div #4525
Conversation
💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:
- Run
yarn lintlocally to catch formatting errors. This will fix some errors automatically, commit and push any changes. - Run
yarn testlocally to catch errors. This ensures all components still behave as they should. - Run
yarn startto run the doc site locally and try a few pages, ensuring everything is in good working order. - Include tests when adding/changing behavior.
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 99.53%. Comparing base (
e0a42b5) to head (41c8fa2).
Additional details and impacted files
@@ Coverage Diff @@ ## master #4525 +/- ## ======================================= Coverage 99.53% 99.53% ======================================= Files 186 186 Lines 3463 3463 ======================================= Hits 3447 3447 Misses 16 16
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Hi! First-time contributor here. The checks passed except Vercel (which seems unrelated). Let me know if any changes are needed. Thanks! 🙌
This pull request fixes issue #4488. It spreads Popper.js's positioning attributes (
attributes.popper) into the Popup wrapper div, allowing for correct accessibility and layout behavior as expected by Popper.js consumers.