Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Adding Kotlin sample project #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 2 commits into SeleniumHQ:dev from krmahadevan:add_kotlin_samples
Jan 17, 2022
Merged

Conversation

@krmahadevan
Copy link
Contributor

@krmahadevan krmahadevan commented Jan 13, 2022 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Adding Kotlin samples

Description

Motivation and Context

Adding Kotlin samples to the examples project as requested by @titusfortner on LinkedIn

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link

CLAassistant commented Jan 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: a8e6fe4

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61dfc68757bc710007f9f442

😎 Browse the preview: https://deploy-preview-925--jovial-austin-42fe02.netlify.app

Copy link

netlify bot commented Jan 13, 2022 •
edited
Loading

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 85320e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61e559f3525f4a000706555b

😎 Browse the preview: https://deploy-preview-925--jovial-austin-42fe02.netlify.app

Copy link
Contributor Author

@titusfortner Pls let me know if there are any changes to be done on this PR before it can be merged.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @krmahadevan!

krmahadevan reacted with heart emoji
@diemol diemol merged commit 022f9db into SeleniumHQ:dev Jan 17, 2022
@diemol diemol mentioned this pull request Jan 17, 2022
6 tasks
@krmahadevan krmahadevan deleted the add_kotlin_samples branch January 17, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /