Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added lambdaTest to the ecosystem page #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@nikhil-lambda
Copy link
Contributor

@nikhil-lambda nikhil-lambda commented Nov 22, 2019
edited by diemol
Loading

Thanks for contributing to the Selenium site and documentation!

A PR well described will help maintainers to quickly review and merge it

LambdaTest is a selenium-as-a-service provider that allows users to run tests on 2000+ different desktop and mobile browser environments. LambdaTest provides an online selenium gird that can be used for this.
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Considering that this is an ecosystem page that showcases all products/ services that complement selenium based testing, I think that LambdaTest is a fitting example of this category. It is similar to most of the products listed here as well.

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after, if needed)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

CLA

diemol
diemol previously approved these changes Nov 22, 2019
@diemol diemol dismissed their stale review November 22, 2019 19:15

PR Needs changes

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nikhil-lambda,
Why is this going into the "Commercial Training" section? Shouldn't it be the "Functional Test Services" section?

@diemol diemol mentioned this pull request Nov 22, 2019
5 tasks
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ diemol
❌ nikhil-lambda
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /