Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update chrome_devtools.en.md add example charp #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
namilkimfree wants to merge 11 commits into SeleniumHQ:dev from namilkimfree:patch-1
Closed

Update chrome_devtools.en.md add example charp #722

namilkimfree wants to merge 11 commits into SeleniumHQ:dev from namilkimfree:patch-1

Conversation

@namilkimfree
Copy link

@namilkimfree namilkimfree commented Jul 1, 2021
edited
Loading

add get console log example c-sharp

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

add get console log example c-sharp
Copy link

CLAassistant commented Jul 1, 2021
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jul 1, 2021
edited
Loading

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 5b31f9d

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/610967d926a3e200073c9730

😎 Browse the preview: https://deploy-preview-722--jovial-austin-42fe02.netlify.app

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @namilkimfree,
Thanks for the PR.

I have a couple of suggestions on this PR:

  1. Code looks good to me, but it can be a shorter code snippet than the code in PR
  2. Code needs to be changed in other translated pages too.
  3. You need to also sign the CLA in order to get this PR merged

Copy link
Member

Hi @namilkimfree ,

Could you please sign the CLA to get this merged!

Copy link
Author

Hi @namilkimfree ,

Could you please sign the CLA to get this merged!

Hi @harsha509

I'm sorry, sign is complete.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namilkimfree, we have updated our site, could you please update the files now in this location?
https://github.com/SeleniumHQ/seleniumhq.github.io/tree/dev/website_and_docs/content/documentation/support_packages

Then we can merge this. Thanks!

Copy link
Member

Hi @namilkimfree,

Thanks for the PR.

As the PR went stale. This PR is replaced with this commit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol requested changes

@harsha509 harsha509 harsha509 requested changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /