Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update Chinese translation of "components_of_a_grid.zh-cn.md" #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@alaahong
Copy link
Member

@alaahong alaahong commented Jun 14, 2021

  • grid/grid_4/components_of_a_grid.zh-cn.md

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link
Member Author

One confused word during my translation. The "Queuer", does that mean the one who want to add into the queue? Or play the queue provider?
In the translation, I treat as the one who want to add into the queue, please correct me if any missed.
Thanks.

Copy link

netlify bot commented Jun 14, 2021
edited
Loading

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 9cbf679

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/60c8b25f94f1b900082f5b87

😎 Browse the preview: https://deploy-preview-714--jovial-austin-42fe02.netlify.app

Copy link
Contributor

One confused word during my translation. The "Queuer", does that mean the one who want to add into the queue? Or play the queue provider?
In the translation, I treat as the one who want to add into the queue, please correct me if any missed.
Thanks.

Thank you for your contribution. Sorry for the confusion. The "Queuer" component is the one only who can talk to the queue. It's the component that performs all actions on the queue and has access to the queue. So it would be more of a queue provider.

Copy link
Member

Hi @alaahong,

Thanks for the PR.

would you like to make changes to this PR based on above comments .?

- grid/grid_4/components_of_a_grid.zh-cn.md
Update based on SeleniumHQ#714 
Copy link
Member Author

One confused word during my translation. The "Queuer", does that mean the one who want to add into the queue? Or play the queue provider?
In the translation, I treat as the one who want to add into the queue, please correct me if any missed.
Thanks.

Thank you for your contribution. Sorry for the confusion. The "Queuer" component is the one only who can talk to the queue. It's the component that performs all actions on the queue and has access to the queue. So it would be more of a queue provider.

Thanks for your following, got the point via above detail.
image

Copy link
Member Author

Hi @alaahong,

Thanks for the PR.

would you like to make changes to this PR based on above comments .?

Yes, just commit as above highlight point.
Thanks

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alaahong !

@harsha509 harsha509 merged commit f73818f into SeleniumHQ:dev Jun 15, 2021
selenium-ci added a commit that referenced this pull request Jun 15, 2021
...deploy site]
* Update Chinese translation of "components_of_a_grid.zh-cn.md"
- grid/grid_4/components_of_a_grid.zh-cn.md
* Update Chinese translation of "components_of_a_grid.zh-cn.md"
- grid/grid_4/components_of_a_grid.zh-cn.md
Update based on #714
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> f73818f 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /