Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update quick.de.md #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsha509 merged 3 commits into SeleniumHQ:dev from f-g-s:patch-1
Jul 4, 2021
Merged

Update quick.de.md #707

harsha509 merged 3 commits into SeleniumHQ:dev from f-g-s:patch-1
Jul 4, 2021

Conversation

@f-g-s
Copy link
Contributor

@f-g-s f-g-s commented Jun 9, 2021 •
edited
Loading

Add German translation for Grid

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.
 

Add German translation for Grid
Copy link

CLAassistant commented Jun 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jun 9, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 876da07

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/60e1be2a27e6fa00083df0af

😎 Browse the preview: https://deploy-preview-707--jovial-austin-42fe02.netlify.app

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @f-g-s ,

Could you please look into the comments above and also could you please sign the CLA to get this merged?

Thanks,
Harsha

the need of running your tests on multiple browser and
operating system combinations.
This is where _[Grid]({{< ref "/grid/_index.md" >}})_ comes into the picture.
Mit Selenium Grid können Tests auf verschiedenen Maschinen auf unterschiedlichen Plattformen ausgeführt werden.
Copy link
Member

@harsha509 harsha509 Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @f-g-s,

Thanks for the PR. Can you please make sure to have a line with a max of 70-80 characters? You can split it into multiple lines if possible.

Thanks,
Harsha

@harsha509 harsha509 added waiting-answer Pending-CLA CLA needs to be signed by Author labels Jun 14, 2021
Copy link
Member

Hi @f-g-s,

Hope you're doing great.

Did you get a chance to look into the above comments?

Thanks!

Copy link
Member

As this PR went stale and didn't get a response from OP.
Merging the code with the required changes!

@harsha509 harsha509 merged commit d1849ed into SeleniumHQ:dev Jul 4, 2021
selenium-ci added a commit that referenced this pull request Jul 4, 2021 
* Update quick.de.md
Add German translation for Grid
* Update quick.de.md
Updating the PR to have 70-80 words in a line
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> d1849ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Labels

Pending-CLA CLA needs to be signed by Author waiting-answer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /