-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add package managers #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package managers #547
Conversation
Added info for Chocolatey users on Windows. Should probably add Homebrew for mac and the major linux package managers, as these are a much simpler way of getting the binaries.
CLA assistant check
All committers have signed the CLA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, @stibinator!
Overall, I think it is a good idea to add this, but please have a look at the comments I left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR should also include the package managers for macOS and Linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to add this, but I don't have access to mac or linux systems to check it on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To move forward with this, maybe you can leave the placeholders for the sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid adding the commands here, we should link to their official page that shows how to use the packages, if we duplicate things here, they can get easily out of date.
@stibinator, please let us know if you'd like to continue with this PR.
Deploy preview for jovial-austin-42fe02 ready!
Built with commit 988b5be
https://deploy-preview-547--jovial-austin-42fe02.netlify.app
This PR has gone stale, we will revisit when comments are addressed.
Added info for Chocolatey users on Windows. Should probably add Homebrew for mac and the major linux package managers, as these are a much simpler way of getting the binaries.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Added info about how to use the Chocolatey package manager to install the binaries.
Motivation and Context
Because the instructions currently don't tell users how to easily download and install the drivers I was about to give up in disgust, when I thought to try chocolatey, and it was ridiculously easy. Using a package manager is by far the easiest way to install and maintain packages like this. Homebrew and dpkg / rpm /yum etc should be added too. That is if you want to reduce the friction for new users.
Types of changes
Checklist