-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DesiredCapabilities, Local file detector using C# #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DesiredCapabilities , Local file detector using C#
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hiroksarker, thanks for this PR.
Can you please make the changes also in the following files?
docs_source_files/content/remote_webdriver/remote_webdriver_client.fr.md docs_source_files/content/remote_webdriver/remote_webdriver_client.nl.md
docs_source_files/content/remote_webdriver/remote_webdriver_client.es.md docs_source_files/content/remote_webdriver/remote_webdriver_client.ja.md docs_source_files/content/remote_webdriver/remote_webdriver_client.zh-cn.md
These changes should be part of this PR as well. Thank you.
Hi @hiroksarker, did you have the chance to check my previous comment?
@diemol yes, following files translation completed.
Not really @hiroksarker, only the English version of the file is changed, what about the other ones?
@diemol all translations competed. Would you please check it!
@diemol Please do not merge this docs change until the C# examples no longer refer to DesiredCapabilities.
I won't @jimevans, thanks for the heads up though.
I think I will make the changes myself and use:
chromeOptions.BrowserVersion = "67";
chromeOptions.PlatformName = "Windows XP";
I'll also remove the DesiredCapabilities text.
...[deploy site] * Completing the translation completed C# Completing the translation completed C# * Completing the translation Completing the translation browser_navigation * Completing the translation for #53 Completing the translation for #53 * Completing the translation for #52 Completing the translation for #52 * Add: Added c# sample code for keyup action * Add: Added JavaScript sample code for remote_webdriver_client * Add: Added JavaScript (Local file detector) for remote_webdriver_client * Transaltion (Local file detector) for remote_webdriver_client.zh-cn * Translation typo * Code considering chrome/firefox drivers * Change driver options calling * Code Optimize Remote WebDriver Client * Browser Options Example Change * To avoid InsecureCertificateError and follow similar example * set desiredcapabilities using javascript
DesiredCapabilities , Local file detector using C#