Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding @Harsha509 as a site & docs committer. #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 3 commits into master from add-Harsha509-as-a-committer
Mar 20, 2020

Conversation

@diemol
Copy link
Member

@diemol diemol commented Mar 19, 2020

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

@harsha509 has been contributing massively to the Selenium official site and docs, and he has also manifested interest to be part of the committers team.

Description

Adding @harsha509 to the structure page where all the committers are shown, thank you @harsha509

Motivation and Context

To recognize someone who is doing a lot for the Selenium project and the community.

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Before:
image
After:
image

AutomatedTester reacted with thumbs up emoji manoj9788 reacted with hooray emoji
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heartily endorsed.

harsha509 reacted with thumbs up emoji harsha509 reacted with heart emoji
@diemol diemol merged commit 26eb76b into master Mar 20, 2020
@diemol diemol deleted the add-Harsha509-as-a-committer branch March 20, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

@p0deje p0deje p0deje approved these changes

@manoj9788 manoj9788 manoj9788 approved these changes

+1 more reviewer

@shs96c shs96c shs96c approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /