-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add translation for page_object_models.zh-cn.md #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @ymang714549348,
Thanks for the PR. Can you please make sure to have a line with a max of 70-80 characters. You can spilt into multiple lines if possible.
Thanks,
Harsha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spilted it inyo multiple lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry,my problem, i will pull the whole repository,and run it ,but it will take some times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ymangz,
How about the punctuation?Is that better if we keep the format in whole page?
Seems there are full width character with different styles of external space in your translated text.
e.g.
口。 测
式 ,在
法。这
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will modify this to like other page of translated
page_object_models.zh-cn.md spilt into multiple line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @Ymangz, could you please make sure each line does not exceed the 70-80 characters limit?
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge itBefore submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.Description
Add translation for page_object_models.zh-cn.md
Motivation and Context
Add translation for page_object_models.zh-cn.md
Types of changes
- Change to the site (I am attaching a screenshot showing the before and after)
- Code example added (and I also added the example to all translated languages)
- Improved translation
- Added new translation (and I also added a notice to each document missing translation)
Checklist
- I have read the contributing document.
- I have used hugo to render the site/docs locally and I am sure it works.
** i can't git clone this repository,because there is a fire wall between china and github**
Just leave a comment.
For seleniumhq.github.io , you can directly clone by git command. I didn't block by greatwall via internet.
For hugo, you can install as the official document --> https://gohugo.io/getting-started/installing/
add translate to page_object_models.zh-cn.md , I have build on my computer. and the max line is < 70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Ymangz! Welcome to the project!
Uh oh!
There was an error while loading. Please reload this page.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add translation for page_object_models.zh-cn.md
Motivation and Context
Add translation for page_object_models.zh-cn.md
Types of changes
Checklist
i can't git clone this repository,because there is a fire wall between china and github