grid_documentation_changes #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

rahuljhakant wants to merge 5 commits into SeleniumHQ:master from rahuljhakant:patch-2

Closed

grid_documentation_changes #306

rahuljhakant wants to merge 5 commits into SeleniumHQ:master from rahuljhakant:patch-2

Conversation

@rahuljhakant

Copy link

Contributor

@rahuljhakant rahuljhakant commented Mar 12, 2020 •

edited

Loading

Changing the grid introduction line

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

Change to the site (I am attaching a screenshot showing the before and after)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)

Checklist

I have read the contributing document.
I have used hugo to render the site/docs locally and I am sure it works.

@rahuljhakant


 grid_documentation_changes

7f65427

Changing the grid introduction line

harsha509

harsha509 requested changes

Mar 12, 2020

View reviewed changes

Copy link

Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @rahuljhakant,

I've suggested a few changes. Also, can you please sure to do changes in other translated pages too.

Thanks,
Harsha

docs_source_files/content/getting_started/quick.en.md Outdated

of learning Selenium script syntax.

## Grid

Selenium Grid is a feature in Selenium that allows you to run test cases in different machines across different platforms. The control of triggering the test cases is on the local machine, and when the test cases are triggered, they are automatically executed by the remote machine

Copy link

Member

@harsha509 harsha509 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rahuljhakant ,

Thanks for the PR. Can you please make sure to have a line width of 70-80

Thanks,
Harsha

docs_source_files/content/getting_started/quick.en.md Outdated Show resolved Hide resolved

@rahuljhakant @harsha509


 Update docs_source_files/content/getting_started/quick.en.md

c316802

changes LGTM
Co-Authored-By: Sri Harsha <Harsha509@users.noreply.github.com>

rahuljhakant

rahuljhakant commented

Mar 12, 2020

View reviewed changes

Copy link

Contributor Author

@rahuljhakant rahuljhakant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are fine.

harsha509

harsha509 requested changes

Mar 12, 2020

View reviewed changes

docs_source_files/content/getting_started/quick.en.md Outdated

## Grid

Selenium Grid allows you to run test cases in different machines across different platforms.

The control of triggering the test cases is on the local end, and when the test cases are triggered, they are automatically executed by the remote end.

Copy link

Member

@harsha509 harsha509 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rahuljhakant ,

Thanks for the PR. There are couple of changes required to get this pr merged.

Limit each line with max of 70-80 characters in line width. For example
this line 'The control of triggering the test cases is on the local end, and when the test cases are triggered, they are' contains 109 chars, you can spilt into two lines
The changes are done for only english version document. Still there are 7 translated pages (french, de, zh-ch, ko, nl etc) the same text changes should be done in those .md pages too.

Please let us know if you still need help.

Regards,
Harsha

Copy link

Contributor Author

@rahuljhakant rahuljhakant Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harsha509 Now I got your point. I will do the translations for all the languages and also Limit each line with a max of 70-80 characters in line width.

diemol

diemol requested changes

Mar 13, 2020

View reviewed changes

Copy link

Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahuljhakant could you please make the changes in the other language files which are still in English?

@harsha509

Copy link

Member

harsha509 commented Mar 21, 2020

Hi @rahuljhakant,

Did you get a chance to look into the changes suggested by @diemol ?

Thanks,
Harsha.

rahuljhakant and others added 2 commits

March 21, 2020 15:18

@rahuljhakant


 Merge branch 'master' into patch-2

c0d86f1


 Updating GRID content in all translating pages

6f02926

@CLAassistant

Copy link

CLAassistant commented Mar 21, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rahuljhakant
❌ Rahul Kant Jha

Rahul Kant Jha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

@rahuljhakant


 GRID doc changes

1a3a65b

@rahuljhakant

Copy link

Contributor Author

rahuljhakant commented Mar 21, 2020

Closing this PR as I'm facing the licensing issue.

@rahuljhakant rahuljhakant closed this

Mar 21, 2020

@rahuljhakant rahuljhakant deleted the patch-2 branch

March 21, 2020 16:34

@rahuljhakant rahuljhakant restored the patch-2 branch

March 21, 2020 16:35

Labels

None yet

4 participants

@rahuljhakant @harsha509 @CLAassistant @diemol

Uh oh!

grid_documentation_changes #306

grid_documentation_changes #306

Uh oh!

Conversation

@rahuljhakant rahuljhakant commented Mar 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

Uh oh!

@harsha509 harsha509 Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@rahuljhakant rahuljhakant left a comment

Choose a reason for hiding this comment

Uh oh!

@harsha509 harsha509 Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

@rahuljhakant rahuljhakant Mar 12, 2020

Choose a reason for hiding this comment

Uh oh!

@diemol diemol left a comment

Choose a reason for hiding this comment

Uh oh!

harsha509 commented Mar 21, 2020

Uh oh!

CLAassistant commented Mar 21, 2020

Uh oh!

rahuljhakant commented Mar 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

@rahuljhakant rahuljhakant commented Mar 12, 2020 •

edited

Loading