Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Issue 2452- fixed line number for CSharp to show correct line for driver #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpallavisharma wants to merge 3 commits into SeleniumHQ:trunk
base: trunk
Choose a base branch
Loading
from rpallavisharma:fix2452

Conversation

@rpallavisharma
Copy link
Member

@rpallavisharma rpallavisharma commented Sep 29, 2025
edited
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

fixed line number for CSharp to show correct line for driver, issue #2452

Motivation and Context

wrong line from code was being displayed

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Bug fix


Description

  • Fixed incorrect line number reference for C# code example

  • Updated line reference from L42 to L48 across multiple language versions

  • Corrected documentation to display proper driver initialization code


Diagram Walkthrough

flowchart LR
 A["Documentation Files"] --> B["Line Reference Update"]
 B --> C["L42 → L48"]
 C --> D["Correct C# Code Display"]
Loading

File Walkthrough

Relevant files
Bug fix
_index.en.md
Fix C# line reference in English docs

website_and_docs/content/documentation/webdriver/drivers/_index.en.md

  • Updated C# code block line reference from L42 to L48
+1/-1
_index.ja.md
Fix C# line reference in Japanese docs

website_and_docs/content/documentation/webdriver/drivers/_index.ja.md

  • Updated C# code block line reference from L42 to L48
+1/-1
_index.pt-br.md
Fix C# line reference in Portuguese docs

website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md

  • Updated C# code block line reference from L42 to L48
+1/-1
_index.zh-cn.md
Fix C# line reference in Chinese docs

website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md

  • Updated C# code block line reference from L42 to L48
+1/-1

Copy link

netlify bot commented Sep 29, 2025
edited
Loading

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0c5bb99

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

2452 - PR Code Verified

Compliant requirements:

  • Update the C# sample on the drivers page to reference the correct line showing driver = new ChromeDriver(options);
  • Ensure the displayed snippet no longer points to the temporary userDataDir line
  • Apply the fix wherever this snippet is referenced across localized docs

Requires further human verification:

  • Verify that /examples/dotnet/SeleniumDocs/BaseTest.cs#L48 indeed contains the driver = new ChromeDriver(options); line in the current default branch (line numbers can drift).
  • Check other localized pages (if any beyond en, ja, pt-br, zh-cn) to confirm all relevant locales are updated.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
Recommended focus areas for review

Line Drift Risk

Hardcoding #L48 may become outdated if BaseTest.cs changes; consider linking to an anchor or a range that is less brittle.

{{< gh-codeblock path="/examples/dotnet/SeleniumDocs/BaseTest.cs#L48" >}}
{{< /tab >}}
Consistency Check

Ensure the same corrected reference is applied across all locales that include this tab set, not just the four updated here.

{{< gh-codeblock path="/examples/dotnet/SeleniumDocs/BaseTest.cs#L48" >}}
{{< /tab >}}

Copy link
Contributor

qodo-merge-pro bot commented Sep 29, 2025
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link

Thank you for making this change. I pulled a clone of the doc repository and have been making changes there, but my progress has been slow and I wasn't sure how the commit/PR process worked here (afraid I'll break something or mess things up... :)

Copy link
Member Author

That's alright. It's been a month and saw no activity or communication so went ahead and fixed it.

I believe things work here like any GitHub project.

Please see this link for further help- https://www.selenium.dev/documentation/about/contributing/

Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /