-
-
Couldn't load subscription status.
- Fork 1.5k
Issue 2452- fixed line number for CSharp to show correct line for driver #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
Here are some key observations to aid the review process:
🎫 Ticket compliance analysis ✅
2452 - PR Code Verified
Compliant requirements:
- Update the C# sample on the drivers page to reference the correct line showing
driver = new ChromeDriver(options); - Ensure the displayed snippet no longer points to the temporary
userDataDirline - Apply the fix wherever this snippet is referenced across localized docs
Requires further human verification:
- Verify that
/examples/dotnet/SeleniumDocs/BaseTest.cs#L48indeed contains thedriver = new ChromeDriver(options);line in the current default branch (line numbers can drift). - Check other localized pages (if any beyond en, ja, pt-br, zh-cn) to confirm all relevant locales are updated.
Line Drift Risk
Hardcoding #L48 may become outdated if BaseTest.cs changes; consider linking to an anchor or a range that is less brittle.
#L48 may become outdated if BaseTest.cs changes; consider linking to an anchor or a range that is less brittle.{{< gh-codeblock path="/examples/dotnet/SeleniumDocs/BaseTest.cs#L48" >}}
{{< /tab >}}Consistency Check
Ensure the same corrected reference is applied across all locales that include this tab set, not just the four updated here.
{{< gh-codeblock path="/examples/dotnet/SeleniumDocs/BaseTest.cs#L48" >}}
{{< /tab >}}PR Code Suggestions ✨
No code suggestions found for the PR.
TheWerewolf
commented
Sep 29, 2025
Thank you for making this change. I pulled a clone of the doc repository and have been making changes there, but my progress has been slow and I wasn't sure how the commit/PR process worked here (afraid I'll break something or mess things up... :)
That's alright. It's been a month and saw no activity or communication so went ahead and fixed it.
I believe things work here like any GitHub project.
Please see this link for further help- https://www.selenium.dev/documentation/about/contributing/
Hope that helps.
Uh oh!
There was an error while loading. Please reload this page.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
fixed line number for CSharp to show correct line for driver, issue #2452
Motivation and Context
wrong line from code was being displayed
Types of changes
Checklist
PR Type
Bug fix
Description
Fixed incorrect line number reference for C# code example
Updated line reference from L42 to L48 across multiple language versions
Corrected documentation to display proper driver initialization code
Diagram Walkthrough
File Walkthrough
_index.en.md
Fix C# line reference in English docswebsite_and_docs/content/documentation/webdriver/drivers/_index.en.md
_index.ja.md
Fix C# line reference in Japanese docswebsite_and_docs/content/documentation/webdriver/drivers/_index.ja.md
_index.pt-br.md
Fix C# line reference in Portuguese docswebsite_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md
_index.zh-cn.md
Fix C# line reference in Chinese docswebsite_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md