Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

adjust development partner #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janetmoreno wants to merge 1 commit into trunk
base: trunk
Choose a base branch
Loading
from adjust_development_partner
Open

Conversation

@janetmoreno
Copy link

@janetmoreno janetmoreno commented Aug 14, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Codify rules for the development partner and clear time requirements for this level of sponsorship

Motivation and Context

Inspired on https://github.com/appium/appium/blob/master/GOVERNANCE.md#sponsorship

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation

Description

  • Clarify development partner sponsorship requirements

  • Specify 50% time commitment for full-time employees

Diagram Walkthrough

flowchart LR
 A["Current Requirements"] --> B["Updated Requirements"]
 B --> C["Full-time Employee"]
 B --> D["50% Time Commitment"]
 C --> E["Active Contribution"]
 D --> E
Loading

File Walkthrough
Relevant files
Documentation
_index.html
Specify development partner time commitment requirements

website_and_docs/content/sponsor/_index.html

  • Updated development partner sponsorship requirements
  • Changed from "at least one employee" to "at least one full-time
    employee"
  • Added specific 50% time commitment requirement for active contribution
+3/-2

Copy link

CLAassistant commented Aug 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Clarity

The phrase "devoted 50% of their time actively contributing" could be clarified to avoid ambiguity (e.g., specify a time window like per week/month and define what counts as "actively contributing").

 
of making a monetary contribution, at least one full-time employee
from your company needs to be devoted 50% of their time actively contributing
to the project.
Consistency

Ensure terminology aligns across the site (e.g., "full-time employee" vs "employee", "Selenium level" reference remains accurate after this change) and that this requirement is reflected wherever sponsorship levels are documented.

 
of making a monetary contribution, at least one full-time employee
from your company needs to be devoted 50% of their time actively contributing
to the project.

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion Impact
General
Clarify time commitment period

The phrase "devoted 50% of their time actively contributing" is ambiguous (e.g.,
over what period?). Specify a clear minimum time window to avoid disputes and
ensure consistent enforcement. Clarify that the 50% commitment is averaged over
a defined period.

website_and_docs/content/sponsor/_index.html [114-116] 

 instead
 of making a monetary contribution, at least one full-time employee
-from your company needs to be devoted 50% of their time actively contributing
+from your company needs to be devoted at least 50% of their working time, averaged over a rolling 3-month period, actively contributing
 to the project.

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies ambiguity in the sponsorship requirement and proposes a specific clarification, which aligns with the PR's intent to make the rules more precise.

Medium
  • More

Copy link

netlify bot commented Aug 14, 2025

✅ Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 0b6d102
🔍 Latest deploy log https://app.netlify.com/projects/selenium-dev/deploys/689dfab3f51ad100088d35e9
😎 Deploy Preview https://deploy-preview-2423--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /