Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[deploy site] removed event details #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpallavisharma merged 1 commit into SeleniumHQ:trunk from rpallavisharma:removeEvent-pal
Jul 30, 2025

Conversation

@rpallavisharma
Copy link
Member

@rpallavisharma rpallavisharma commented Jul 30, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

removed event details

Description

removed event details

Motivation and Context

removed event details

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Other

Description

  • Removed Selenium Community Live event announcement banner

  • Disabled announcement banner functionality in site configuration

Diagram Walkthrough

flowchart LR
 A["Event Banner HTML"] -- "remove content" --> B["Empty Banner"]
 C["Hugo Config"] -- "disable flags" --> D["Banner Disabled"]
Loading

File Walkthrough
Relevant files
Content removal
announcement-banner.html
Remove event announcement content

website_and_docs/layouts/partials/announcement-banner.html

  • Removed event announcement heading and link
  • Left empty alert div structure in place
+1/-4
Configuration changes
hugo.toml
Disable announcement banner flags

website_and_docs/hugo.toml

  • Set banner_flag from true to false
  • Set announcement_banner from true to false
+2/-2

Copy link

netlify bot commented Jul 30, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 11a1adb

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Empty Content

The alert div now contains only whitespace, which may render an empty banner on the site. Consider removing the entire banner section or adding conditional rendering to avoid displaying empty content.

 
<div class="alert alert-{{ $color }} col-12 fade show mb-0 p-0 -bg-{{ $color }}" role="alert">
</div>

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion Impact
General
Remove empty alert content

The empty alert div with styling classes serves no purpose and creates
unnecessary DOM elements. Since the banner flags are disabled in the config,
this entire section should be removed or the content should be properly cleaned
up.

website_and_docs/layouts/partials/announcement-banner.html [7-9] 

 <div class="alert alert-{{ $color }} col-12 fade show mb-0 p-0 -bg-{{ $color }}" role="alert">
- 
+ <!-- Event announcement content will be added here when needed -->
 </div>
  • Apply / Chat
Suggestion importance[1-10]: 4

__

Why: The suggestion correctly identifies that the PR leaves an empty div, and adding a comment as proposed improves maintainability by clarifying the element's purpose.

Low
  • More

@rpallavisharma rpallavisharma merged commit ecbcdaa into SeleniumHQ:trunk Jul 30, 2025
3 checks passed
@rpallavisharma rpallavisharma deleted the removeEvent-pal branch July 30, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /