Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[deploy site] toml file and improved message #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpallavisharma merged 1 commit into SeleniumHQ:trunk from rpallavisharma:fixToml-pal
Jul 28, 2025

Conversation

@rpallavisharma
Copy link
Member

@rpallavisharma rpallavisharma commented Jul 28, 2025 •
edited
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

toml file and improved message

Description

toml file and improved message

Motivation and Context

toml file and improved message

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Other

Description

  • Uncommented ignoreErrors configuration in Hugo TOML

  • Improved grammar in ecosystem page text

Diagram Walkthrough

flowchart LR
 A["Hugo TOML config"] -- "uncomment ignoreErrors" --> B["Fixed configuration"]
 C["Ecosystem page"] -- "grammar improvement" --> D["Better text quality"]
Loading

File Walkthrough
Relevant files
Configuration changes
hugo.toml
Uncomment ignoreErrors configuration

website_and_docs/hugo.toml

  • Uncommented the ignoreErrors configuration line
+1/-1
Documentation
_index.html
Improve grammar in ecosystem description

website_and_docs/content/ecosystem/_index.html

  • Changed "you're" to "you are" and "we'd" to "we would" for better
    grammar
+1/-1

Copy link

netlify bot commented Jul 28, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f92c5cb

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Configuration Change

The ignoreErrors configuration has been commented out, which means Hugo will no longer ignore remote JSON errors. This could potentially cause build failures if there are issues with remote JSON fetching that were previously being ignored.

 
#ignoreErrors = ["error-remote-getjson"]
# Language settings

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion Impact
Possible issue
Restore error handling configuration

Commenting out ignoreErrors will cause Hugo to fail on remote JSON fetch errors
that were previously ignored. This could break the site build if any remote JSON
endpoints are unavailable or return errors.

website_and_docs/hugo.toml [9] 

-#ignoreErrors = ["error-remote-getjson"]
+ignoreErrors = ["error-remote-getjson"]
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies that commenting out ignoreErrors could cause the entire site build to fail if a remote JSON endpoint is unavailable, which is a critical issue.

High
  • More

@rpallavisharma rpallavisharma merged commit 6c93117 into SeleniumHQ:trunk Jul 28, 2025
3 checks passed
Copy link
Member Author

Hi @diemol , the build deploy is failing. https://github.com/SeleniumHQ/seleniumhq.github.io/actions/runs/16571269124
Can you when you have time please help me understand steps to fix this. Thanks.

Copy link
Member

diemol commented Jul 29, 2025

Seems something changed in GItHub API and malformatted URLs were being accepted. I fixed it through 48b97e9. This failure was not related to this PR.
rpallavisharma reacted with thumbs up emoji

Copy link
Member Author

Thank you for the help @diemol , thanks for sharing the issue resolution .

@rpallavisharma rpallavisharma deleted the fixToml-pal branch July 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol Awaiting requested review from diemol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /