Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix curl command name, syntax, and url #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 3 commits into SeleniumHQ:trunk from cgoldberg:curl-name
Jul 10, 2025
Merged

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Jul 9, 2025 •
edited
Loading

User description

Description

This PR fixes the name of the curl command used in: https://www.selenium.dev/documentation/grid/advanced_features/endpoints/

Also:

  • Fixes an example with invalid syntax
  • updates the URL of the official curl website to https://curl.se/ across the documentation.

Motivation and Context

curl is the proper name of the command.
Also, cURL probably doesn't work on case-sensitive file systems.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation

Description

  • Fix curl command name from cURL to curl in documentation

  • Update command references across multiple language versions

  • Correct minor typo in English documentation

Changes diagram

flowchart LR
 A["Documentation Files"] --> B["Fix cURL to curl"]
 B --> C["Update Command Examples"]
 B --> D["Fix Text References"]
 C --> E["Multiple Languages Updated"]
Loading

Changes walkthrough 📝

Relevant files
Documentation
endpoints.en.md
Fix curl command name and typo

website_and_docs/content/documentation/grid/advanced_features/endpoints.en.md

  • Changed all instances of cURL to curl in command examples
  • Updated text references from "cURL command" to "curl command"
  • Fixed typo: "pings the node status are regular" to "at regular"
    • +26/-26
    endpoints.ja.md
    Fix curl command name in Japanese

    website_and_docs/content/documentation/grid/advanced_features/endpoints.ja.md

  • Changed all instances of cURL to curl in command examples
  • Updated Japanese text references from "cURL コマンド" to "curl コマンド"
    • +25/-25
    endpoints.pt-br.md
    Fix curl command name in Portuguese

    website_and_docs/content/documentation/grid/advanced_features/endpoints.pt-br.md

  • Changed all instances of cURL to curl in command examples
  • Updated Portuguese text references from "comando cURL" to "comando
    curl"
    • +25/-25
    endpoints.zh-cn.md
    Fix curl command name in Chinese

    website_and_docs/content/documentation/grid/advanced_features/endpoints.zh-cn.md

  • Changed all instances of cURL to curl in command examples
  • Updated Chinese text references from "cURL 命令" to "curl 命令"
    • +25/-25
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    Copy link

    netlify bot commented Jul 9, 2025 •
    edited
    Loading

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 404bc7e

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion Impact
    Possible issue
    ✅ (削除) Fix curl command syntax (削除ここまで)
    Suggestion Impact:The suggestion was implemented with a slight variation - instead of using -X GET, the commit used --request GET, which is functionally equivalent and fixes the same syntax issue

    code diff:

    -curl GET 'http://localhost:4444/status'
+curl --request GET 'http://localhost:4444/status'

    The curl command syntax is incorrect. The HTTP method should be specified with
    the -X flag, not as a standalone argument. This will cause the command to fail
    when executed.

    website_and_docs/content/documentation/grid/advanced_features/endpoints.en.md [19] 

    -curl GET 'http://localhost:4444/status'
+curl -X GET 'http://localhost:4444/status'

    [Suggestion processed]

    Suggestion importance[1-10]: 7

    __

    Why: The suggestion correctly identifies that the curl command syntax is invalid; the GET method should be specified with the -X flag or omitted, as it's the default.

    		Medium
    • Update

    @cgoldberg cgoldberg changed the title (削除) Fix curl command name and url (削除ここまで) (追記) Fix curl command name, syntax, and url (追記ここまで) Jul 9, 2025
    @diemol diemol merged commit 93be037 into SeleniumHQ:trunk Jul 10, 2025
    3 checks passed
    selenium-ci added a commit that referenced this pull request Jul 10, 2025 
    * Fix curl command name
* Fix curl url
* Fix command syntax
[deploy site] 93be037
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @diemol diemol diemol approved these changes

    Assignees

    No one assigned

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    AltStyle によって変換されたページ (->オリジナル) /