Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update link to minimum java version #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohabMohie wants to merge 1 commit into SeleniumHQ:trunk
base: trunk
Choose a base branch
Loading
from MohabMohie:patch-1

Conversation

@MohabMohie
Copy link
Contributor

@MohabMohie MohabMohie commented Jun 22, 2025 •
edited by qodo-merge-pro bot
Loading

PR Type

Documentation

Description

  • Update link to correct line number for minimum Java version

Changes walkthrough 📝

Relevant files
Documentation
install_library.en.md
Fix minimum Java version link reference

website_and_docs/content/documentation/webdriver/getting_started/install_library.en.md

  • Updated GitHub link line number from L13 to L27 for minimum Java
    version reference
    • +1/-1
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    Copy link

    netlify bot commented Jun 22, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit f5969e6

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Link Verification

    The GitHub link line number was updated from L13 to L27. Should verify that the new line number L27 actually contains the minimum Java version information in the referenced file.

     
    View the minimum supported Java version [here](https://github.com/SeleniumHQ/selenium/blob/trunk/.bazelrc#L27).

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Could you please update the links from the translated files that are in the same directory?

    Copy link
    Member

    Could you please update the links from the translated files that are in the same directory?

    Hi @diemol , just mentioned this PR, seems the contributor point the minimum version to Java 21, it might be confused to all java user.
    image

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @diemol diemol diemol requested changes

    Requested changes must be addressed to merge this pull request.

    Assignees

    No one assigned

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /