Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

add privacy policy #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
titusfortner wants to merge 2 commits into trunk
base: trunk
Choose a base branch
Loading
from privacy
Open

add privacy policy #2187

titusfortner wants to merge 2 commits into trunk from privacy

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Feb 21, 2025 •
edited by qodo-merge-pro bot
Loading

User description

  • Create a Privacy Policy
  • Create a Blog Post describing the need for the privacy policy

This content assumes that we merge SeleniumHQ/selenium#15317

Feedback appreciated

PR Type

Documentation, Enhancement

Description

  • Added a comprehensive Privacy Policy page detailing data collection practices.

  • Introduced a blog post explaining the Privacy Policy and telemetry.

  • Updated footer and navigation to include Privacy Policy links.

  • Configured Hugo to reference the new Privacy Policy.

Changes walkthrough 📝

Relevant files
Documentation
_index.html
Added comprehensive Privacy Policy page

website_and_docs/content/privacy/_index.html

  • Created a detailed Privacy Policy page.
  • Explained data collection and compliance with GDPR/CCPA.
  • Provided opt-out instructions for telemetry.
  • Highlighted transparency with public analytics dashboards.
    • +238/-0
    selenium-privacy-policy.md
    Blog post explaining Privacy Policy and telemetry

    website_and_docs/content/blog/2025/selenium-privacy-policy.md

  • Published a blog post introducing the Privacy Policy.
  • Explained telemetry data collection and opt-out options.
  • Shared insights from telemetry data.
    • +79/-0
    Enhancement
    footer.html
    Added Privacy Policy link to footer

    website_and_docs/layouts/partials/footer.html

  • Updated footer to include Privacy Policy link.
  • Adjusted formatting for footer links.
    • +1/-1
    Configuration changes
    hugo.toml
    Configured Hugo for Privacy Policy integration

    website_and_docs/hugo.toml

  • Updated Hugo configuration to reference Privacy Policy.
  • Added Privacy Policy to navigation menu under "About".
    • +7/-1
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    MohabMohie and harsha509 reacted with thumbs up emoji
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 Security concerns

    Email exposure:
    The privacy policy page exposes an email address (plc@seleniumhq.org) which could potentially be harvested by bots for spam. Consider using a contact form or obfuscating the email address.

    ⚡ Recommended focus areas for review

    Broken HTML

    Missing closing

  • tag in the Storage & Security section which could cause rendering issues
    •  
     Everything Selenium Manager collects is publicly accessible in the
 <a href="https://plausible.io/manager.selenium.dev">Selenium Manager Plausible Dashboard</a> for full
 transparency.
 </li>
</ul>
    Typo

    Typo in feedback section: "out implementations" should be "our implementations"

     
    If you have suggestions for how we can improve out implementations, please reach out to the Selenium
team:

    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 21, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion Impact
    General
    Add policy last-updated date

    Add a clear timestamp or last-updated date to the Privacy Policy page to help
    users understand when the policy was last modified and ensure transparency about
    policy changes.

    website_and_docs/content/privacy/_index.html [14-16] 

     <div class="mx-auto text-center p-4">
 <h1 class="d-1">Selenium Privacy Policy</h1>
+ <p class="text-muted mt-2">Last Updated: February 21, 2025</p>
 </div>
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    __

    Why: Adding a last-updated date is a best practice for privacy policies, helping users understand policy currency and demonstrating transparency about policy changes. This is particularly important for compliance documentation.

    		Medium
    Add navigation table of contents

    Add a table of contents at the top of the privacy policy to help users quickly
    navigate to specific sections, improving accessibility and user experience.

    website_and_docs/content/privacy/_index.html [14-17] 

     <div class="mx-auto text-center p-4">
 <h1 class="d-1">Selenium Privacy Policy</h1>
 </div>
 {{< /blocks/section >}}
 
+<div class="row p-5">
+ <div class="w-lg-75 mx-auto">
+ <h3>Contents</h3>
+ <ul>
+ <li><a href="#commitment">Selenium's Commitment to Privacy</a></li>
+ <li><a href="#analytics">Website Analytics</a></li>
+ <li><a href="#telemetry">Selenium Manager Telemetry</a></li>
+ <li><a href="#compliance">GDPR & CCPA Compliance</a></li>
+ <li><a href="#opt-out">How to Opt Out</a></li>
+ <li><a href="#feedback">Feedback</a></li>
+ </ul>
+ </div>
+</div>
+
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    __

    Why: A table of contents would improve navigation and accessibility of this long privacy policy document, helping users quickly find relevant sections. The implementation correctly uses anchor links to existing sections.

    		Low
    • Update

    Copy link

    netlify bot commented Feb 21, 2025 •
    edited
    Loading

    ✅ Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 08fa373
    🔍 Latest deploy log https://app.netlify.com/projects/selenium-dev/deploys/68a2359a525e9c00080e07d7
    😎 Deploy Preview https://deploy-preview-2187--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    ---
    title: "Selenium Privacy Policy"
    linkTitle: "Selenium Privacy Policy"
    date: 2025年02月19日
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    date: 2025-02-19
    date: 2025-08-17

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @diemol diemol diemol approved these changes

    Assignees

    No one assigned

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /