Skip to content

Add: Added python and csharp code samples in doc Mouse action in detail #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

diemol merged 3 commits into SeleniumHQ:master from hiroksarker:master

Feb 4, 2020

Merged

Add: Added python and csharp code samples in doc Mouse action in detail #203

diemol merged 3 commits into SeleniumHQ:master from hiroksarker:master

Feb 4, 2020

Conversation

Copy link

Contributor

@hiroksarker hiroksarker commented Feb 3, 2020 •

edited

Loading

Description

Motivation and Context

Types of changes

Change to the site (I am attaching a screenshot showing the before and after)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)

Checklist

I have read the contributing document.
I have used hugo to render the site/docs locally and I am sure it works.

hiroksarker added 2 commits

February 3, 2020 15:16


 Added python sample code mouse and keyboard actions

f6a04bd


 Added csharp sample code mouse and keyboard actions

f49ac0e

@hiroksarker hiroksarker changed the title ~~(削除) Added python sample code mouse and keyboard actions (削除ここまで)~~ (追記) Added python and csharp sample code mouse and keyboard actions (追記ここまで)

@hiroksarker hiroksarker changed the title ~~(削除) Added python and csharp sample code mouse and keyboard actions (削除ここまで)~~ (追記) Add: Added python and csharp code samples in doc Mouse action in detail (追記ここまで)

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.en.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.en.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.es.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.en.md Outdated Show resolved Hide resolved

harsha509 requested changes

View reviewed changes

Copy link

Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hiroksarker,

I've provided a few comments on this PR.

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved

harsha509 reviewed

View reviewed changes

docs_source_files/content/support_packages/mouse_and_keyboard_actions_in_detail.de.md Outdated Show resolved Hide resolved


 Fixed code alignment and changes

becc759

Copy link

Contributor Author

hiroksarker commented Feb 3, 2020

Hi @hiroksarker,

I've provided a few comments on this PR.

Thanks, fixed code alignment, and variable name change

harsha509 approved these changes

View reviewed changes

Copy link

Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

diemol approved these changes

View reviewed changes

Copy link

Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hiroksarker! Perhaps the next PRs can be a bit smaller please 🙏
Thanks, @harsha509 for reviewing!

@diemol diemol merged commit b577bc3 into SeleniumHQ:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@hiroksarker @diemol @harsha509