Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Updated navigation.en.md for picking the new changes to webUI #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rupesh253 wants to merge 1 commit into SeleniumHQ:trunk from Rupesh253:patch-2

Conversation

@Rupesh253
Copy link

@Rupesh253 Rupesh253 commented Oct 14, 2024 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation

Description

  • Updated the CSharp code block reference in the navigation documentation to include a wider range of lines, from #L17-L20 to #L17-L22.
  • This change ensures that the documentation accurately reflects the relevant code example for better clarity and understanding.

Changes walkthrough 📝

Relevant files
Documentation
navigation.en.md
Update CSharp code block reference in navigation documentation

website_and_docs/content/documentation/webdriver/interactions/navigation.en.md

  • Updated code block reference for CSharp example.
  • Changed line range from #L17-L20 to #L17-L22.
    • +1/-1

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Oct 14, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 773f4a6

    Copy link

    CLA assistant check
    Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
    You have signed the CLA already but the status is still pending? Let us recheck it.

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 1 labels Oct 14, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Rupesh253 Rupesh253 changed the title (削除) Update navigation.en.md (削除ここまで) (追記) Updatednavigation.en.md for picking the new changes to webUI (追記ここまで) Oct 14, 2024
    @Rupesh253 Rupesh253 changed the title (削除) Updatednavigation.en.md for picking the new changes to webUI (削除ここまで) (追記) Updated navigation.en.md for picking the new changes to webUI (追記ここまで) Oct 14, 2024
    Copy link
    Contributor

    Thank you for your contribution @Rupesh253 !

    First off, before any of your PRs can be merged, you must sign the Contributor License Agreement.

    Second, it looks like this pr is based on your other PR #1996. You will need to merge these prs into one single pr for them to be accepted.

    Copy link

    @A1exKH A1exKH left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @Rupesh253
    please check this comment (click) and address required changes in your PR.

    Copy link
    Member

    Hi @Rupesh253,

    Thank you for your contribution!

    I appreciate the effort to clarify the differences between driver.Url and driver.Navigate().GoToUrl. However, for the context provided, our goal is to show the usage of both driver.Url and driver.Navigate().GoToUrl, without detailing the types of arguments they accept. Including the additional notes on Uri and string arguments may add unnecessary complexity for our intended audience in docs.

    For simplicity and consistency, we'll keep the original explanations focused on basic usage examples. Thanks again for the suggestion, and we welcome further contributions!

    Closing as Not Planned!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @A1exKH A1exKH A1exKH requested changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /