Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Transparent png favicons #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsha509 merged 3 commits into SeleniumHQ:trunk from nvborisenko:favicon-transparent
Sep 10, 2024
Merged

Conversation

@nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Sep 10, 2024 •
edited by qodo-merge-pro bot
Loading

User description

Description

Before:
image

After:
image
image

Motivation and Context

Sync icons.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

enhancement, documentation

Description

  • Updated reference links across multiple documentation files to remove leading slashes, ensuring consistency and correctness.
  • Enhanced the security configuration in hugo.toml by allowing git as an executable.

Changes walkthrough 📝

Relevant files
Documentation
21 files
_index.ja.md
Update reference links for consistency in Japanese documentation

website_and_docs/content/documentation/_index.ja.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    _index.pt-br.md
    Update reference links for consistency in Portuguese documentation

    website_and_docs/content/documentation/_index.pt-br.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    _index.zh-cn.md
    Update reference links for consistency in Chinese documentation

    website_and_docs/content/documentation/_index.zh-cn.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    components.en.md
    Update reference links for consistency in English grid components
    documentation

    website_and_docs/content/documentation/grid/components.en.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    components.ja.md
    Update reference links for consistency in Japanese grid components
    documentation

    website_and_docs/content/documentation/grid/components.ja.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    components.pt-br.md
    Update reference links for consistency in Portuguese grid components
    documentation

    website_and_docs/content/documentation/grid/components.pt-br.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    components.zh-cn.md
    Update reference links for consistency in Chinese grid components
    documentation

    website_and_docs/content/documentation/grid/components.zh-cn.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    getting_started.en.md
    Update reference links for consistency in English grid getting started
    documentation

    website_and_docs/content/documentation/grid/getting_started.en.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +3/-3
    getting_started.ja.md
    Update reference links for consistency in Japanese grid getting
    started documentation

    website_and_docs/content/documentation/grid/getting_started.ja.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    getting_started.pt-br.md
    Update reference links for consistency in Portuguese grid getting
    started documentation

    website_and_docs/content/documentation/grid/getting_started.pt-br.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +3/-3
    getting_started.zh-cn.md
    Update reference links for consistency in Chinese grid getting started
    documentation

    website_and_docs/content/documentation/grid/getting_started.zh-cn.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +3/-3
    _index.ja.md
    Update reference links for consistency in Japanese overview
    documentation

    website_and_docs/content/documentation/overview/_index.ja.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    _index.pt-br.md
    Update reference links for consistency in Portuguese overview
    documentation

    website_and_docs/content/documentation/overview/_index.pt-br.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    _index.zh-cn.md
    Update reference links for consistency in Chinese overview
    documentation

    website_and_docs/content/documentation/overview/_index.zh-cn.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    details.ja.md
    Update reference links for consistency in Japanese overview details

    website_and_docs/content/documentation/overview/details.ja.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    details.pt-br.md
    Update reference links for consistency in Portuguese overview details

    website_and_docs/content/documentation/overview/details.pt-br.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    details.zh-cn.md
    Update reference links for consistency in Chinese overview details

    website_and_docs/content/documentation/overview/details.zh-cn.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +1/-1
    overview.en.md
    Update reference links for consistency in English test practices
    overview

    website_and_docs/content/documentation/test_practices/overview.en.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    overview.ja.md
    Update reference links for consistency in Japanese test practices
    overview

    website_and_docs/content/documentation/test_practices/overview.ja.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    overview.pt-br.md
    Update reference links for consistency in Portuguese test practices
    overview

    website_and_docs/content/documentation/test_practices/overview.pt-br.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    overview.zh-cn.md
    Update reference links for consistency in Chinese test practices
    overview

    website_and_docs/content/documentation/test_practices/overview.zh-cn.md

  • Updated reference links to remove leading slashes.
  • Improved link consistency across the document.
    • +2/-2
    Configuration changes
    1 files
    hugo.toml
    Update security configuration to allow git execution

    website_and_docs/hugo.toml

  • Added git to the list of allowed executables in the security
    configuration.
    • +1/-1

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    harsha509 reacted with rocket emoji
    Copy link

    netlify bot commented Sep 10, 2024 •
    edited
    Loading

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 963a886

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 2 labels Sep 10, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Security Configuration
    The PR adds 'git' to the list of allowed executables in the security configuration. This change should be carefully reviewed to ensure it doesn't introduce any security vulnerabilities.

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion Score
    Enhancement
    Improve sentence structure for better readability and comprehension

    Consider rephrasing the sentence to improve clarity and flow. The current structure
    is a bit complex and might be difficult to understand at first glance.

    website_and_docs/content/documentation/grid/components.zh-cn.md [70] 

    -+默认情况下,**Node**会自动注册其所在机器上路径中可用的所有浏览器驱动程序。它还为基于Chromium的浏览器和Firefox创建每个可用CPU一个插槽。对于Safari,只创建一个插槽。通过特定的[配置]({{< ref "configuration" >}}),它可以在Docker容器中运行会话或转发命令。
++默认情况下,**Node**会自动注册其所在机器上路径中可用的所有浏览器驱动程序。对于基于Chromium的浏览器和Firefox,它会为每个可用的CPU创建一个插槽。而对于Safari,只创建一个插槽。通过特定的[配置]({{< ref "configuration" >}}),**Node**还可以在Docker容器中运行会话或转发命令。
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The rephrased sentence improves clarity and flow, making the technical content easier to understand, which is particularly beneficial in documentation.

    		8
    Use a more specific and easily understandable term for "race conditions" in Japanese

    Consider using a more specific term instead of "競合状態" to describe the concept of
    race conditions in the context of browser automation. A term like "タイミング問題" or
    "同期の問題" might be more appropriate and easier to understand for Japanese readers.

    website_and_docs/content/documentation/test_practices/overview.ja.md [28] 

    -+後の章では、特にブラウザーとWebDriver間の[競合状態を克服する]({{< ref "waits.md" >}})方法に関する、テストでの断続的な問題を軽減するために使用できる手法に戻ります。
++後の章では、特にブラウザーとWebDriver間の[タイミング問題を克服する]({{< ref "waits.md" >}})方法に関する、テストでの断続的な問題を軽減するために使用できる手法に戻ります。
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion improves clarity by using a term that might be more familiar to Japanese readers, enhancing the document's accessibility and comprehension.

    		7
    Use a more idiomatic Chinese phrase for "For simplicity" in the documentation

    Consider using a more idiomatic Chinese phrase for "For simplicity". Instead of
    "为简单起见", you could use "为了简化说明" which is more commonly used in technical
    documentation.

    website_and_docs/content/documentation/grid/getting_started.zh-cn.md [212] 

    -+为简单起见,本页中显示的所有命令示例均假定组件正在运行在本地。更详细的示例和用法可以在[配置组件]({{< ref "configuration" >}}) 部分。
++为了简化说明,本页中显示的所有命令示例均假定组件正在运行在本地。更详细的示例和用法可以在[配置组件]({{< ref "configuration" >}}) 部分。
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: The suggestion enhances the readability of the document by using a more commonly used phrase in technical documentation, which can help readers better understand the content.

    		6
    Security
    Improve security by using a more specific regex pattern for the git executable

    Consider using a more specific regex pattern for the git executable to enhance
    security. Instead of allowing any executable with 'git' in its name, you could use a
    pattern that matches the exact 'git' command.

    website_and_docs/hugo.toml [343] 

    +allow = ['^dart-sass-embedded$', '^go$', '^npx$', '^postcss$', '^git$']
 
-
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion to use a more specific regex pattern for the 'git' executable enhances security by preventing unintended executables with 'git' in their name from being allowed. This is a significant improvement in terms of security best practices.

    		8

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @nvborisenko !

    @harsha509 harsha509 merged commit 03705be into SeleniumHQ:trunk Sep 10, 2024
    Copy link
    Member Author

    I should notice I built this PR on top of #1936

    selenium-ci added a commit that referenced this pull request Sep 10, 2024 
    * Fix ref links
* Transparent png favicons
---------
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 03705be
    @nvborisenko nvborisenko deleted the favicon-transparent branch September 10, 2024 11:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @harsha509 harsha509 harsha509 approved these changes

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /