Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Themed favicon #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsha509 merged 3 commits into SeleniumHQ:trunk from nvborisenko:themed-favicon
Sep 9, 2024
Merged

Themed favicon #1934

harsha509 merged 3 commits into SeleniumHQ:trunk from nvborisenko:themed-favicon
Sep 9, 2024

Conversation

@nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Sep 9, 2024
edited by qodo-merge-pro bot
Loading

User description

Description

This is continuation of #1932

Motivation and Context

It should resolve favicon for dark mode.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

enhancement


Description


Changes walkthrough 📝

Relevant files

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

netlify bot commented Sep 9, 2024
edited
Loading

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cd91d01

@qodo-merge-pro qodo-merge-pro bot added the enhancement New feature or request label Sep 9, 2024
Copy link
Contributor

qodo-merge-pro bot commented Sep 9, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nvborisenko !

@harsha509 harsha509 merged commit b8096f8 into SeleniumHQ:trunk Sep 9, 2024
selenium-ci added a commit that referenced this pull request Sep 9, 2024
* Themed favicon with transparent background
* Update favicon.ico
---------
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> b8096f8 
@nvborisenko nvborisenko deleted the themed-favicon branch September 10, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /