Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

removed hanging '>' #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsha509 merged 1 commit into SeleniumHQ:trunk from shbenzer:hanging>
Aug 27, 2024
Merged

removed hanging '>' #1896

harsha509 merged 1 commit into SeleniumHQ:trunk from shbenzer:hanging>
Aug 27, 2024

Conversation

@shbenzer
Copy link
Contributor

@shbenzer shbenzer commented Aug 26, 2024 •
edited by qodo-merge-pro bot
Loading

User description

there was a hanging '>' character in locator strategies

Description

removed hanging '>' character at the end of Utilizing Locators section description in all languages
also ensured line-count was below 100 chars in the descriptions of all languages for Utilizing Locators

Motivation and Context

increases readability

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation

Description

  • Removed a hanging '>' character from the end of the "Utilizing Locators" section in multiple language documentation files.
  • Reformatted the text to ensure that line lengths do not exceed 100 characters, improving readability.

Changes walkthrough 📝

Relevant files
Documentation
locators.en.md
Fix formatting and remove extraneous character in English locators
documentation

website_and_docs/content/documentation/webdriver/elements/locators.en.md

  • Removed a hanging '>' character.
  • Reformatted text to ensure line length is below 100 characters.
    • +3/-1
    locators.ja.md
    Fix formatting and remove extraneous character in Japanese locators
    documentation

    website_and_docs/content/documentation/webdriver/elements/locators.ja.md

  • Removed a hanging '>' character.
  • Reformatted text to ensure line length is below 100 characters.
    • +3/-1
    locators.pt-br.md
    Fix formatting and remove extraneous character in Portuguese locators
    documentation

    website_and_docs/content/documentation/webdriver/elements/locators.pt-br.md

  • Removed a hanging '>' character.
  • Reformatted text to ensure line length is below 100 characters.
    • +3/-1
    locators.zh-cn.md
    Fix formatting and remove extraneous character in Chinese locators
    documentation

    website_and_docs/content/documentation/webdriver/elements/locators.zh-cn.md

  • Removed a hanging '>' character.
  • Reformatted text to ensure line length is below 100 characters.
    • +3/-1

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Aug 26, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit deab103

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 1 labels Aug 26, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion Score
    Best practice
    Correct the capitalization of a method name to follow common naming conventions

    Consider capitalizing 'FindElement' to 'findElement' as it's typically written in
    camelCase in most programming languages.

    website_and_docs/content/documentation/webdriver/elements/locators.en.md [335-337] 

    -The FindElement makes using locators a breeze! For most languages, 
+The findElement makes using locators a breeze! For most languages, 
 all you need to do is utilize `webdriver.common.by.By`, however in 
-others it's as simple as setting a parameter in the FindElement function
+others it's as simple as setting a parameter in the findElement function
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion to use camelCase for 'findElement' aligns with common programming conventions, improving readability and consistency with typical method naming practices.

    		7
    Enhancement
    Add proper punctuation at the end of a sentence

    Consider adding a period at the end of the sentence to improve readability and
    maintain consistency in punctuation.

    website_and_docs/content/documentation/webdriver/elements/locators.en.md [335-337] 

     The FindElement makes using locators a breeze! For most languages, 
 all you need to do is utilize `webdriver.common.by.By`, however in 
-others it's as simple as setting a parameter in the FindElement function
+others it's as simple as setting a parameter in the FindElement function.
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: Adding a period at the end of the sentence enhances readability and maintains punctuation consistency, though it is a minor improvement.

    		5

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @shbenzer !

    @harsha509 harsha509 merged commit 1ec0ee1 into SeleniumHQ:trunk Aug 27, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @harsha509 harsha509 harsha509 approved these changes

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /