Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add logo for TestingBot (bronze sponsor) #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 2 commits into SeleniumHQ:trunk from jochen-testingbot:trunk
Aug 21, 2024

Conversation

@jochen-testingbot
Copy link
Contributor

@jochen-testingbot jochen-testingbot commented Aug 20, 2024 •
edited by qodo-merge-pro bot
Loading

User description

Description

This PR adds the logo for TestingBot (bronze sponsor) to the sponsor page.

Thank you & keep up the good work!

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

enhancement, documentation

Description

  • Added TestingBot as a bronze sponsor to the sponsors list in the sponsors.yml file.
  • Included TestingBot's logo, URL, and name for display on the sponsor page.

Changes walkthrough 📝

Relevant files
Enhancement
sponsors.yml
Add TestingBot as a bronze sponsor in YAML file

website_and_docs/data/sponsors.yml

  • Added TestingBot logo to bronze sponsors.
  • Included TestingBot sponsorship details.
    • +4/-0

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Aug 20, 2024 •
    edited
    Loading

    ✅ Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit c984267
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/66c591a1bb3a0200088ca536
    😎 Deploy Preview https://deploy-preview-1877--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link

    CLAassistant commented Aug 20, 2024 •
    edited
    Loading

    CLA assistant check
    All committers have signed the CLA.

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 1 labels Aug 20, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    qodo-merge-pro bot commented Aug 20, 2024 •
    edited
    Loading

    PR Code Suggestions ✨

    CategorySuggestion Score
    Maintainability
    Reorder sponsor entries to maintain chronological order based on sponsorship start dates

    Consider reordering the new sponsor entry to maintain chronological order based on
    sponsorship start dates. This would improve readability and make it easier to manage
    sponsor listings over time.

    website_and_docs/data/sponsors.yml [97-104] 

    +# Sponsorship start date: Jul 12, 2024
+- logo: "/images/sponsors/route4me-logo.png"
+ url: "https://route4me.com/"
+ name: "Route Planner and Route Optimizer - Route4Me Inc."
 # Sponsorship start date: Aug 13, 2024
 - logo: "/images/sponsors/testingbot.png"
 url: "https://testingbot.com/"
 name: "Selenium Cloud Testing - TestingBot"
-# Sponsorship start date: Jul 12, 2024
-- logo: "/images/sponsors/route4me-logo.png"
- url: "https://route4me.com/"
- name: "Route Planner and Route Optimizer - Route4Me Inc."
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Reordering the sponsor entries to maintain chronological order enhances readability and manageability of the sponsor list, making it easier to track and update sponsorships over time.

    		8
    Consistency
    Standardize the format of sponsorship dates and improve consistency in sponsor name presentation

    Consider using a consistent date format for the sponsorship start date comments. The
    existing format is 'MMM DD, YYYY', but the new entry uses 'Aug 13, 2024'. Align it
    with the existing format for better readability and consistency.

    website_and_docs/data/sponsors.yml [97-100] 

     # Sponsorship start date: Aug 13, 2024
 - logo: "/images/sponsors/testingbot.png"
 url: "https://testingbot.com/"
- name: "Selenium Cloud Testing - TestingBot"
+ name: "TestingBot - Selenium Cloud Testing"
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion to standardize the date format improves readability and consistency, which is beneficial for maintaining the document. However, the suggestion also includes a change to the sponsor name presentation that was not part of the original PR code diff, which slightly reduces its relevance.

    		7

    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you, @jochen-testingbot!

    @diemol diemol merged commit 38402f3 into SeleniumHQ:trunk Aug 21, 2024
    selenium-ci added a commit that referenced this pull request Aug 21, 2024 
    * Add logo for TestingBot (bronze sponsor)
[deploy site]
---------
Co-authored-by: Diego Molina <diemol@gmail.com>
[deploy site] 38402f3
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @diemol diemol diemol approved these changes

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /