Feature 1539 #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

shbenzer wants to merge 7 commits into SeleniumHQ:trunk from shbenzer:feature-1539

Closed

Feature 1539 #1871

shbenzer wants to merge 7 commits into SeleniumHQ:trunk from shbenzer:feature-1539

Conversation

@shbenzer

Copy link

Contributor

@shbenzer shbenzer commented Aug 19, 2024 •

edited by qodo-merge-pro bot

Loading

User description

commit for feature #1539

Description

added example differentiating between .// and // when utilizing xpath
added to all translations

Motivation and Context

increase documentation coverage

Types of changes

Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)

Checklist

I have read the contributing document.
I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation, enhancement

Description

Added setup and teardown functions in Python Selenium tests to improve test organization.
Introduced examples for using Selenium Manager, demonstrating setup with and without it.
Enhanced documentation by adding sections on implementing Selenium Manager in scripts across multiple languages.
Provided examples and explanations for using XPATH in element finders, highlighting the importance of using "." for current elements.
Updated Selenium getting started guides to include setup and teardown instructions for Python.

Changes walkthrough 📝

Relevant files

Relevant files
Enhancement	2 files using_selenium_tests.py `Add setup and teardown functions for Selenium tests` examples/python/tests/getting_started/using_selenium_tests.py Added `setup` and `teardown` functions for Selenium tests. Improved test organization with setup and teardown. +8/-0 usage.py `Add examples for Selenium Manager usage` examples/python/tests/selenium_manager/usage.py Added examples for using Selenium Manager. Demonstrated setup with and without Selenium Manager. +12/-0
Documentation	9 files selenium_manager.en.md `Document Selenium Manager implementation in scripts` website_and_docs/content/documentation/selenium_manager.en.md Added section on implementing Selenium Manager in scripts. Included Python code examples for Selenium Manager. +23/-0 selenium_manager.ja.md `Document Selenium Manager implementation in scripts` website_and_docs/content/documentation/selenium_manager.ja.md Added section on implementing Selenium Manager in scripts. Included Python code examples for Selenium Manager. +23/-0 selenium_manager.pt-br.md `Document Selenium Manager implementation in scripts` website_and_docs/content/documentation/selenium_manager.pt-br.md Added section on implementing Selenium Manager in scripts. Included Python code examples for Selenium Manager. +23/-0 selenium_manager.zh-cn.md `Document Selenium Manager implementation in scripts` website_and_docs/content/documentation/selenium_manager.zh-cn.md Added section on implementing Selenium Manager in scripts. Included Python code examples for Selenium Manager. +23/-0 finders.en.md `Add XPATH usage examples in element finders` website_and_docs/content/documentation/webdriver/elements/finders.en.md Added examples for using XPATH from current element. Explained the use of "." in XPATH for current elements. +12/-0 finders.ja.md `Add XPATH usage examples in element finders` website_and_docs/content/documentation/webdriver/elements/finders.ja.md Added examples for using XPATH from current element. Explained the use of "." in XPATH for current elements. +11/-0 finders.zh-cn.md `Add XPATH usage examples in element finders` website_and_docs/content/documentation/webdriver/elements/finders.zh-cn.md Added examples for using XPATH from current element. Explained the use of "." in XPATH for current elements. +11/-0 using_selenium.en.md `Document setup and teardown in Selenium guide` website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md Added setup and teardown sections for Python. Linked to Python code examples for setup and teardown. +9/-0 using_selenium.ja.md `Document setup and teardown in Selenium guide` website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md Added setup and teardown sections for Python. Linked to Python code examples for setup and teardown. +9/-0

Enhancement

2 files

using_selenium_tests.py

Add setup and teardown functions for Selenium tests

examples/python/tests/getting_started/using_selenium_tests.py

Added setup and teardown functions for Selenium tests.

Improved test organization with setup and teardown.

+8/-0

usage.py

Add examples for Selenium Manager usage

examples/python/tests/selenium_manager/usage.py

Added examples for using Selenium Manager.

Demonstrated setup with and without Selenium Manager.

+12/-0

Documentation

9 files

selenium_manager.en.md

Document Selenium Manager implementation in scripts

website_and_docs/content/documentation/selenium_manager.en.md

Added section on implementing Selenium Manager in scripts.

Included Python code examples for Selenium Manager.

+23/-0

selenium_manager.ja.md

Document Selenium Manager implementation in scripts

website_and_docs/content/documentation/selenium_manager.ja.md

Added section on implementing Selenium Manager in scripts.

Included Python code examples for Selenium Manager.

+23/-0

selenium_manager.pt-br.md

Document Selenium Manager implementation in scripts

website_and_docs/content/documentation/selenium_manager.pt-br.md

Added section on implementing Selenium Manager in scripts.

Included Python code examples for Selenium Manager.

+23/-0

selenium_manager.zh-cn.md

Document Selenium Manager implementation in scripts

website_and_docs/content/documentation/selenium_manager.zh-cn.md

Added section on implementing Selenium Manager in scripts.

Included Python code examples for Selenium Manager.

+23/-0

finders.en.md

Add XPATH usage examples in element finders

website_and_docs/content/documentation/webdriver/elements/finders.en.md

Added examples for using XPATH from current element.

Explained the use of "." in XPATH for current elements.

+12/-0

finders.ja.md

Add XPATH usage examples in element finders

website_and_docs/content/documentation/webdriver/elements/finders.ja.md

Added examples for using XPATH from current element.

Explained the use of "." in XPATH for current elements.

+11/-0

finders.zh-cn.md

Add XPATH usage examples in element finders

website_and_docs/content/documentation/webdriver/elements/finders.zh-cn.md

Added examples for using XPATH from current element.

Explained the use of "." in XPATH for current elements.

+11/-0

using_selenium.en.md

Document setup and teardown in Selenium guide

website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md

Added setup and teardown sections for Python.

Linked to Python code examples for setup and teardown.

+9/-0

using_selenium.ja.md

Document setup and teardown in Selenium guide

website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md

Added setup and teardown sections for Python.

Linked to Python code examples for setup and teardown.

+9/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

shbenzer added 4 commits

August 18, 2024 17:11

@shbenzer


 added setup and teardown python examples to Organizing and Executing ...

9ddfec6

...Selenium Code

@shbenzer


 added examples for selenium manager to documentation

bbded46

@shbenzer


 added example of xpath differentiating b/w .// and // to Find element...

5fe24f3

... from element section

@shbenzer


 added feature to other languages

01f0372

@netlify

Copy link

netlify bot commented Aug 19, 2024 •

edited

Loading

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`18ae80e`

@qodo-merge-pro qodo-merge-pro bot added documentation enhancement labels

Aug 19, 2024

@qodo-merge-pro

Copy link

Contributor

qodo-merge-pro bot commented Aug 19, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review

Hardcoded Path
The setup_without_selenium_manager function uses a hardcoded path for the Chrome executable, which may not be portable across different systems.

Inconsistent Indentation
The added code blocks have inconsistent indentation, which may affect readability and potentially cause issues in Python code examples.

@qodo-merge-pro qodo-merge-pro bot added the Review effort [1-5]: 2 label

Aug 19, 2024

@diemol diemol mentioned this pull request

Aug 19, 2024

Added Setup and Teardown Python Examples to Organizing and Executing Selenium Code #1868

Merged

6 tasks

shbenzer added 2 commits

August 19, 2024 09:19

@shbenzer


 Merge branch 'trunk' into feature-1539

e477d19

@shbenzer


 Merge branch 'trunk' into feature-1539

cb304aa

@diemol

Copy link

Member

diemol commented Aug 19, 2024

Feature 1539 does not mention Selenium Manager, but this PR does. Can you please clarify? I merged a moment ago some changes related to Selenium Manager.

@shbenzer

Copy link

Contributor Author

shbenzer commented Aug 19, 2024

@diemol I realized with this push that my other changes were being integrated into my PR, so I included them in the description to make review easier

@shbenzer


 Merge branch 'trunk' into feature-1539

18ae80e

@shbenzer shbenzer closed this

Aug 19, 2024

Labels

documentation enhancement Review effort [1-5]: 2

2 participants

@shbenzer @diemol

Uh oh!

Feature 1539 #1871

Feature 1539 #1871

Uh oh!

Conversation

@shbenzer shbenzer commented Aug 19, 2024 • edited by qodo-merge-pro bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Description

Motivation and Context

Types of changes

Checklist

PR Type

Description

Changes walkthrough 📝

Uh oh!

netlify bot commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy request for selenium-dev pending review.

Uh oh!

qodo-merge-pro bot commented Aug 19, 2024

PR Reviewer Guide 🔍

Uh oh!

diemol commented Aug 19, 2024

Uh oh!

shbenzer commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

@shbenzer shbenzer commented Aug 19, 2024 •

edited by qodo-merge-pro bot

Loading

netlify bot commented Aug 19, 2024 •

edited

Loading