-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added Python Examples to Organizing and Executing Selenium Code #1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
Code Duplication
The driver.quit() call is duplicated in both the test function and the teardown function. Consider removing it from the test function to avoid redundancy.
Missing Context
The added Python setup and teardown examples lack explanatory text. Consider adding brief descriptions to explain the purpose and usage of these functions.
Untranslated Content
The added Python setup and teardown examples in the Japanese version are not translated. Consider translating the headers and any explanatory text to Japanese for consistency.
PR Code Suggestions ✨
|
Is this PR duplicating #1868?
@diemol It seems that each of my 4 PRs includes the previous in it
OK, so please either split them or have a single one.
For the future, it is better to have separate change sets.
@diemol Would you like me to cancel all of these prs and merge them into one?
#1868 was merged.
Is that not needed in the other files?
I'm just ensuring that the merge will be easier at the end - I didn't remove any commits from the pr
Why are only the Japanese and English files changed?
I'll fix the remaining two prs
Uh oh!
There was an error while loading. Please reload this page.
User description
Added Execution Example to Organizing and Executing Selenium Code
Description
Updated english and japanese versions of Organizing and Executing Selenium Code page to include lines of python code for execution
Motivation and Context
needed documentation
Types of changes
Checklist
PR Type
Documentation, Enhancement
Description
setupandteardownfunctions inusing_selenium_tests.pyto manage WebDriver lifecycle.Changes walkthrough 📝
using_selenium_tests.py
Add setup and teardown functions for Selenium testsexamples/python/tests/getting_started/using_selenium_tests.py
setupfunction to initialize the WebDriver and open a URL.teardownfunction to quit the WebDriver.using_selenium.en.md
Update English documentation with Python exampleswebsite_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md
using_selenium.ja.md
Update Japanese documentation with Python exampleswebsite_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md
instructions.